Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/solana priority fees #7916

Merged
merged 3 commits into from
Sep 26, 2024
Merged

Bugfix/solana priority fees #7916

merged 3 commits into from
Sep 26, 2024

Conversation

hzheng-ledger
Copy link
Contributor

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

It is a duplication of the PR: https://github.com/hoodieshq/ledger-live/pull/4/files

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@hzheng-ledger hzheng-ledger requested a review from a team as a code owner September 26, 2024 08:10
@vercel Vercel
Copy link

vercel bot commented Sep 26, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2024 8:18am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Sep 26, 2024 8:18am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 26, 2024 8:18am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 26, 2024 8:18am

@vercel Vercel
Copy link

vercel bot commented Sep 26, 2024

@mikhd is attempting to deploy a commit to the LedgerHQ Team on Vercel.

A member of the Team first needs to authorize it.

@live-github-bot live-github-bot bot added common Has changes in live-common fork Pull request base branch comes from a fork. labels Sep 26, 2024
@hzheng-ledger hzheng-ledger merged commit 396025a into LedgerHQ:bugfix/solana-priority-fees Sep 26, 2024
22 of 24 checks passed
hzheng-ledger added a commit that referenced this pull request Oct 4, 2024
@hzheng-ledger @mikhd
Bugfix/solana priority fees (#7916) (#7917)
87b706c 
* Bugfix/solana priority fees (#7916)

* chore(LLC): update @solana/[email protected], @solana/[email protected]

* feat(LLC): calc and possibly append priority fee to solana instructions

* feat(LLC): add solana compute units optimisations

---------

Co-authored-by: Mikhail <[email protected]>

* fix: add changeset

* fix: unit tests and solana min app version

---------

Co-authored-by: Mikhail <[email protected]>
hedi-edelbloute added a commit that referenced this pull request Oct 11, 2024
@hedi-edelbloute
Revert "Bugfix/solana priority fees (#7916) (#7917)"
d917480 
This reverts commit 87b706c.
hedi-edelbloute added a commit that referenced this pull request Oct 11, 2024
@hedi-edelbloute
Merge pull request #8073 from LedgerHQ/support/revert-sol-priority-fees
972625b 
Revert "Bugfix/solana priority fees (#7916) (#7917)"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hzheng-ledger hzheng-ledger

Labels
common Has changes in live-common fork Pull request base branch comes from a fork.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hzheng-ledger @mikhd