Bugfix/solana priority fees (#7916) #7917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore(LLC): update @solana/[email protected], @solana/[email protected] * feat(LLC): calc and possibly append priority fee to solana instructions * feat(LLC): add solana compute units optimisations --------- Co-authored-by: Mikhail <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Skipped Deployments
|
hedi-edelbloute
added a commit
that referenced
this pull request
Oct 11, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore(LLC): update @solana/[email protected], @solana/[email protected]
feat(LLC): calc and possibly append priority fee to solana instructions
feat(LLC): add solana compute units optimisations
✅ Checklist
npx changesetwas attached.📝 Description
It is a duplicate of https://github.com/hoodieshq/ledger-live/pull/4/files
Issue:
https://support.ledger.com/hc/en-us/articles/17531561702813-Temporary-issue-with-Staking-and-Sending-Solana-SOL-in-Ledger-Live-Your-transaction-may-have-failed?support=true
Solution
Advised solution to mitigate this is to estimate and add Priority Fee to the transaction to make it accepted by validators faster.
Calculate and request optimal amount of Compute Units required for tx
Note:
Required getRecentPrioritizationFees rpc call solana-labs/solana-web3.js#1464 in @solana/[email protected].
Hence, @solana/web3.js and @solana/spl-token have been updated.
❓ Context
🧐 Checklist for the PR Reviewers