Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: solana priority fees [LIVE-11792] #8234

Merged
merged 10 commits into from
Nov 13, 2024
Merged

Conversation

Justkant
Copy link
Contributor

@Justkant Justkant commented Oct 29, 2024

✅ Checklist

📝 Description

Original work: hoodieshq#4 (related LL PR: #7917)

Reverted because of swap issue: #8073

Issue:

https://support.ledger.com/hc/en-us/articles/17531561702813-Temporary-issue-with-Staking-and-Sending-Solana-SOL-in-Ledger-Live-Your-transaction-may-have-failed?support=true

Solution

Advised solution to mitigate this is

Note:

Required getRecentPrioritizationFees rpc call doesn't work correctly in @solana/[email protected]. Hence, @solana/web3.js and @solana/spl-token have been updated.

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@Justkant Justkant self-assigned this Oct 29, 2024
@Justkant Justkant requested a review from a team as a code owner October 29, 2024 10:41
Copy link

vercel bot commented Oct 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 7:40am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 7:40am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 7:40am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 7:40am
web-tools ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 7:40am

@live-github-bot live-github-bot bot added the common Has changes in live-common label Oct 29, 2024
@live-github-bot
Copy link
Contributor

live-github-bot bot commented Oct 29, 2024

Desktop Bundle Checks

Comparing f377cd4 against b40b73d.

⚠️ superstruct library is now duplicated in renderer (regression)

Mobile Bundle Checks

Comparing f377cd4 against b40b73d.

⚠️ main.ios.jsbundle bundle size significantly increased: 62.8mb -> 63mb. Please check if this is expected.
⚠️ main.android.jsbundle bundle size significantly increased: 62.8mb -> 63.1mb. Please check if this is expected.

Wozacosta
Wozacosta previously approved these changes Oct 31, 2024
qperrot
qperrot previously approved these changes Nov 12, 2024
@Justkant
Copy link
Contributor Author

Just saw that I'm missing a changeset adding it now

@Justkant Justkant force-pushed the bugfix/solana-priority-fees branch from 1b61a4c to cad783e Compare November 13, 2024 07:39
@Justkant Justkant merged commit f232030 into develop Nov 13, 2024
55 checks passed
@Justkant Justkant deleted the bugfix/solana-priority-fees branch November 13, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common desktop Has changes in LLD mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants