-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mirror of 220 on original repo #1
Conversation
replace dead code for group scaching in playernames module add a sanity check for toast button in originalbuttons module
refactor backdrop compatibility for bcc and classic era
Thank you for the submission. Please let me know if you are interested in being an expert reviewer. So far I can only really read the code enough to know "this looks safe enough". I'm kind of taking a bit of a leap of faith. Looking at past contributors of Prat, it was basically all Jon, only a handful of PRs from other contributors. Also, I should have the curseforge account wired up very soon, within the next few days. Hopefully your changes will get things moving again. Thanks so much |
I don't know what expert reviewer means in this context. Foremost among them I do not play all versions of World of Warcraft. Far as authors/contributors. Finally, the PR you merged is fairly well tested in Classic Era and BC Classic but as said I do not play Shadowlands or even have it installed and I've no idea if there are issues with it in mainline WoW, especially with 9.1 patch recently released. |
Hey thanks a lot, I really appreciate your reply! The referrals are important, I've interacted briefly with MysticalOS, I'll reach out to all 3 of them once I get the Curseforge account wired up to the new repo. That's actually incredibly helpful as I'm not really involved in the community beyond being the person that broke the bad news, referrals make my role in all this much easier. |
This is simply a mirror of the pull request that fixes Prat-3.0 for BCC (compatible with Classic Era as well)