Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirror of 220 on original repo #1

Merged
merged 10 commits into from
Jul 5, 2021

Conversation

Road-block
Copy link

@Road-block Road-block commented Jul 2, 2021

This is simply a mirror of the pull request that fixes Prat-3.0 for BCC (compatible with Classic Era as well)

@Devinmarra Devinmarra merged commit dc25801 into Legacy-of-Sylvanaar:master Jul 5, 2021
@Devinmarra
Copy link

Thank you for the submission. Please let me know if you are interested in being an expert reviewer. So far I can only really read the code enough to know "this looks safe enough". I'm kind of taking a bit of a leap of faith. Looking at past contributors of Prat, it was basically all Jon, only a handful of PRs from other contributors.

Also, I should have the curseforge account wired up very soon, within the next few days. Hopefully your changes will get things moving again. Thanks so much

@Road-block
Copy link
Author

Road-block commented Jul 5, 2021

I don't know what expert reviewer means in this context.
I'm not interested in taking over maintenance of Prat-3.0 for a couple reasons.

Foremost among them I do not play all versions of World of Warcraft.
I only play classic / BCC and since Prat is an addon with a substantial userbase on mainline WoW it would be best supported by someone or a team that spans classic / mainline.
Secondly it is a very popular addon and those tend to become a "job", I'm not prepared to do that for a hobby endeavor 😋

Far as authors/contributors.
With the risk of seemingly excluding some talented developer freshly entering the addon crafting scene (there's many of those) people like humfras, MysticalOS or pompachomp that have been involved in Prat and WiM in the past are trustworthy.
They've been making addons for years, they have really popular addons under their belt and so on.
Whether they would be willing to take over maintenance of Prat is another matter entirely.

Finally, the PR you merged is fairly well tested in Classic Era and BC Classic but as said I do not play Shadowlands or even have it installed and I've no idea if there are issues with it in mainline WoW, especially with 9.1 patch recently released.

@Devinmarra
Copy link

Hey thanks a lot, I really appreciate your reply! The referrals are important, I've interacted briefly with MysticalOS, I'll reach out to all 3 of them once I get the Curseforge account wired up to the new repo. That's actually incredibly helpful as I'm not really involved in the community beyond being the person that broke the bad news, referrals make my role in all this much easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants