Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manually merged LibreCAD2 changes #20

Merged
merged 7 commits into from
Oct 18, 2021
Merged

manually merged LibreCAD2 changes #20

merged 7 commits into from
Oct 18, 2021

Conversation

lordofbikes
Copy link
Member

This is the result of syncing independent changes to libdxfrw from LibreCAD 2 and LibreCAD 3.
It brings more stability for reading DWG files, but there is still work to do.
We should take care to keep this repo and the LibreCAD_2 embedded code in sync now.

@feragon, before merging this branch, we have to check the LibreCAD_3 implementation for 2 new abstract methods in the interface.

virtual void addPlotSettings(const DRW_PlotSettings *data) = 0;

virtual void writeObjects() = 0;

@lordofbikes lordofbikes self-assigned this Aug 14, 2021
@lordofbikes lordofbikes mentioned this pull request Aug 22, 2021
@lordofbikes lordofbikes merged commit f5404fa into master Oct 18, 2021
@lordofbikes lordofbikes mentioned this pull request Oct 18, 2021
@lordofbikes lordofbikes deleted the mergeLibreCAD2 branch November 4, 2022 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant