Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More modernization and cleanups #26

Merged
merged 8 commits into from
Aug 14, 2021
Merged

Conversation

nyalldawson
Copy link
Contributor

No description provided.

@lordofbikes
Copy link
Member

@feragon before merging this and succeeding PR's let me check about #20.
I hold #20 back because of changes in the interface, which should be implemented in @LibreCAD/librecad-3 parallel, to avoid conflicts when new users download both to build.
I haven't checked yet, but some issues fixed by @nyalldawson, may already be fixed in my branch.
Alternatively, we can merge these new PR's and mine into a new branch or create a tag for the latest commit to use with LibreCAD_3. Or maybe both.

@nyalldawson
Copy link
Contributor Author

@lordofbikes

Alternatively, we can merge these new PR's and mine into a new branch or create a tag for the latest commit to use with LibreCAD_3

I'd suggest the second option - have a separate branch for librecad3 and keep the master branch as the recommended upstream for cross-application use

@nyalldawson
Copy link
Contributor Author

For reference I've started collating fixes in https://github.com/qgis/libdxfrw . I still plan on migrating them all here when you're ready for contributions, so ping me when you're ready! 👍

@lordofbikes lordofbikes merged commit ae1f66f into LibreCAD:master Aug 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants