Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEST-536: Update OC #829

Merged
merged 39 commits into from
Aug 23, 2024
Merged
Show file tree
Hide file tree
Changes from 16 commits
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
18531e7
Update OC preview version.
sarahelsaig Jul 29, 2024
ff1f47b
dummy
sarahelsaig Jul 29, 2024
cdf39ba
Temporarily disable nuget checks.
sarahelsaig Jul 30, 2024
cd22fb9
Restore nuget checks.
sarahelsaig Jul 30, 2024
07a973e
Update OC preview versions.
sarahelsaig Jul 30, 2024
9300e69
Fix package downgrade.
sarahelsaig Jul 30, 2024
9009eae
Republish Lombiq.ChartJs.
sarahelsaig Jul 30, 2024
feb449d
Republish ChartJS and BaseTheme.
sarahelsaig Jul 30, 2024
69588ff
Fix package downgrade.
sarahelsaig Jul 30, 2024
34b3967
Update Lombiq.Hosting.MediaTheme.
sarahelsaig Jul 30, 2024
f01f137
submodules
sarahelsaig Aug 20, 2024
01469cc
OC version.
sarahelsaig Aug 20, 2024
38bbba4
Merge branch 'task/system-text-json-migration' into issue/NEST-536
sarahelsaig Aug 20, 2024
7e890f2
OC verson.
sarahelsaig Aug 20, 2024
8526857
cloudflare
sarahelsaig Aug 20, 2024
fda3a6b
Lombiq.Privacy nuget
sarahelsaig Aug 20, 2024
068d838
Update cacheBustingParameterName.
sarahelsaig Aug 20, 2024
5e0e291
Revert "Remove code path from FileVersionProviderDecorator that will …
sarahelsaig Aug 20, 2024
e8f9ea1
Updating submodules
Piedone Aug 21, 2024
8b86503
MD formatting
Piedone Aug 21, 2024
11f9fc2
submodules
sarahelsaig Aug 22, 2024
e02104e
Update OC preview version.
sarahelsaig Aug 22, 2024
3bd247d
Merge remote-tracking branch 'origin/issue/NEST-536' into issue/NEST-536
sarahelsaig Aug 22, 2024
9f508c2
Update Unix visver.
sarahelsaig Aug 22, 2024
537ba1c
submodule
sarahelsaig Aug 22, 2024
2d844c5
Override settings shapes to fix the "option > em" problem.
sarahelsaig Aug 22, 2024
d43b963
Spell check ignore.
sarahelsaig Aug 22, 2024
e529462
submodule
sarahelsaig Aug 23, 2024
f79eaba
Merge branch 'task/system-text-json-migration' into issue/NEST-536
sarahelsaig Aug 23, 2024
15a311d
Update OC preview version.
sarahelsaig Aug 23, 2024
b947193
Update OC preview version.
sarahelsaig Aug 23, 2024
f79c18a
Use JS click when ClickReliablyOnUntilUrlChangeAsync is being weird.
sarahelsaig Aug 23, 2024
f412f53
Same for "Content type editor".
sarahelsaig Aug 23, 2024
ef908fb
Add necessary delay for step that didn't connect.
sarahelsaig Aug 23, 2024
694b811
Fix walkthrough branch.
sarahelsaig Aug 23, 2024
d69cb13
Fix ESLint warnings.
sarahelsaig Aug 23, 2024
195cd87
Delete useless shape overrides.
sarahelsaig Aug 23, 2024
226e2fb
Move exceptions into the plan yml file.
sarahelsaig Aug 23, 2024
56d751f
submodules
sarahelsaig Aug 23, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/actions/spelling/expect.txt
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ Bubl
chartjs
Chro
chromedriver
cloudflare
clike
codeanalysis
codestyle
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/validate-pull-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,4 @@ on:
jobs:
validate-pull-request:
name: Validate Pull Request
uses: Lombiq/GitHub-Actions/.github/workflows/validate-pull-request.yml@issue/OSOE-888
uses: Lombiq/GitHub-Actions/.github/workflows/validate-pull-request.yml@dev
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,8 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="OrchardCore.Logging.NLog" Version="2.0.0-preview-18312" />
<PackageReference Include="OrchardCore.Application.Cms.Targets" Version="2.0.0-preview-18312" />
<PackageReference Include="OrchardCore.Logging.NLog" Version="2.0.0-preview-18315" />
<PackageReference Include="OrchardCore.Application.Cms.Targets" Version="2.0.0-preview-18315" />
</ItemGroup>

<ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@

<ItemGroup>
<PackageReference Include="Lombiq.HelpfulLibraries" Version="10.0.1-alpha.4.osoe-893" />
<PackageReference Include="OrchardCore.Module.Targets" Version="2.0.0-preview-18312" />
<PackageReference Include="OrchardCore.ContentManagement" Version="2.0.0-preview-18312" />
<PackageReference Include="OrchardCore.ContentTypes.Abstractions" Version="2.0.0-preview-18312" />
<PackageReference Include="OrchardCore.DisplayManagement" Version="2.0.0-preview-18312" />
<PackageReference Include="OrchardCore.Module.Targets" Version="2.0.0-preview-18315" />
<PackageReference Include="OrchardCore.ContentManagement" Version="2.0.0-preview-18315" />
<PackageReference Include="OrchardCore.ContentTypes.Abstractions" Version="2.0.0-preview-18315" />
<PackageReference Include="OrchardCore.DisplayManagement" Version="2.0.0-preview-18315" />
</ItemGroup>

</Project>
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@

<ItemGroup>
<PackageReference Include="Lombiq.Npm.Targets" Version="1.4.0" />
<PackageReference Include="OrchardCore.Theme.Targets" Version="2.0.0-preview-18312" />
<PackageReference Include="OrchardCore.ContentManagement" Version="2.0.0-preview-18312" />
<PackageReference Include="OrchardCore.DisplayManagement" Version="2.0.0-preview-18312" />
<PackageReference Include="OrchardCore.ResourceManagement" Version="2.0.0-preview-18312" />
<PackageReference Include="OrchardCore.Theme.Targets" Version="2.0.0-preview-18315" />
<PackageReference Include="OrchardCore.ContentManagement" Version="2.0.0-preview-18315" />
<PackageReference Include="OrchardCore.DisplayManagement" Version="2.0.0-preview-18315" />
<PackageReference Include="OrchardCore.ResourceManagement" Version="2.0.0-preview-18315" />
</ItemGroup>

</Project>
6 changes: 3 additions & 3 deletions src/Lombiq.OSOCE.Web/Lombiq.OSOCE.Web.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,9 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="OrchardCore.Admin.Abstractions" Version="2.0.0-preview-18312" />
<PackageReference Include="OrchardCore.Application.Cms.Targets" Version="2.0.0-preview-18312" />
<PackageReference Include="OrchardCore.Logging.NLog" Version="2.0.0-preview-18312" />
<PackageReference Include="OrchardCore.Admin.Abstractions" Version="2.0.0-preview-18315" />
<PackageReference Include="OrchardCore.Application.Cms.Targets" Version="2.0.0-preview-18315" />
<PackageReference Include="OrchardCore.Logging.NLog" Version="2.0.0-preview-18315" />
<PackageReference Include="SixLabors.ImageSharp.Web" Version="3.1.3" />
</ItemGroup>

Expand Down
18 changes: 18 additions & 0 deletions src/Lombiq.OSOCE.Web/Views/Settings-Cache.Edit.cshtml
Piedone marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
@* Copied from OC on 2024-08-22. All difference is that the <em> elements were removed to pacify Chrome. *@

@model OrchardCore.Settings.ViewModels.SiteSettingsViewModel

<h5>@T["Settings for dynamic caches"]</h5>

<div class="mb-3">
<div class="col-xl-6" asp-validation-class-for="CacheMode">
<label asp-for="CacheMode" class="form-label">@T["Cache Mode"]</label>
<select asp-for="CacheMode" class="form-select">
<option value="@CacheMode.FromConfiguration.ToString()">@T["From environment — enabled in Production, disabled otherwise"]</option>
<option value="@CacheMode.Enabled.ToString()">@T["Enabled"]</option>
<option value="@CacheMode.DebugEnabled.ToString()">@T["Enabled with cache debug mode"]</option>
<option value="@CacheMode.Disabled.ToString()">@T["Disabled"]</option>
</select>
<span class="hint">@T["Determines whether caches are enabled or disabled."]</span>
</div>
</div>
40 changes: 40 additions & 0 deletions src/Lombiq.OSOCE.Web/Views/Settings-Resources.Edit.cshtml
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
@* Copied from OC on 2024-08-22. All difference is that the <em> elements were removed to pacify Chrome. *@

@model SiteSettingsViewModel

<h5>@T["Settings for scripts and stylesheets"]</h5>

<div class="mb-3" asp-validation-class-for="AppendVersion">
<div class="form-check">
<input type="checkbox" class="form-check-input" asp-for="@Model.AppendVersion" />
<label class="form-check-label" asp-for="@Model.AppendVersion">@T["Use resources cache busting"]</label>
<span class="hint dashed">@T["Whether cache busting (append a version) is used for scripts and stylesheets"]</span>
</div>
</div>

<div class="mb-3" asp-validation-class-for="UseCdn">
<div class="form-check">
<input type="checkbox" class="form-check-input" asp-for="@Model.UseCdn" />
<label class="form-check-label" asp-for="@Model.UseCdn">@T["Use framework CDN (Content Delivery Network)"]</label>
<span class="hint dashed">@T["Whether a framework CDN is used for registered scripts and stylesheets, such as jQuery, or their local version"]</span>
</div>
</div>

<div class="mb-3" asp-validation-class-for="CdnBaseUrl">
<label asp-for="CdnBaseUrl" class="form-label">@T["Site CDN (Content Delivery Network) base url"]</label>
<input asp-for="CdnBaseUrl" class="form-control" />
<span asp-validation-for="CdnBaseUrl"></span>
<span class="hint">@T["A base CDN URL prefixed to the local scripts and stylesheets. It is disabled if the value is empty or if the Resource Debug Mode is enabled, e.g. https://cdn.mysite.com"]</span>
</div>

<div class="mb-3">
<div class="col-xl-6" asp-validation-class-for="ResourceDebugMode">
<label asp-for="ResourceDebugMode" class="form-label">@T["Resource Debug Mode"]</label>
<select asp-for="ResourceDebugMode" class="form-select">
<option value="@ResourceDebugMode.FromConfiguration.ToString()">@T["From environment — disabled in Production, enabled otherwise"]</option>
<option value="@ResourceDebugMode.Enabled.ToString()">@T["Enabled — use debuggable version of resources"]</option> @* #spell-check-ignore-line *@
<option value="@ResourceDebugMode.Disabled.ToString()">@T["Disabled — use minified version of resources"]</option>
</select>
<span class="hint">@T["Determines whether scripts and stylesheets load in their debuggable or minified form."]</span> @* #spell-check-ignore-line *@
</div>
</div>
11 changes: 11 additions & 0 deletions src/Lombiq.OSOCE.Web/Views/_ViewImports.cshtml
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
@inherits OrchardCore.DisplayManagement.Razor.RazorPage<TModel>

@addTagHelper *, Microsoft.AspNetCore.Mvc.TagHelpers
@addTagHelper *, OrchardCore.Contents.TagHelpers
@addTagHelper *, OrchardCore.DisplayManagement
@addTagHelper *, OrchardCore.ResourceManagement
@addTagHelper *, Lombiq.UIKit

@using Microsoft.AspNetCore.Mvc.TagHelpers
@using OrchardCore.Settings
@using OrchardCore.Settings.ViewModels
8 changes: 4 additions & 4 deletions src/Modules/Lombiq.OSOCE.Samples/Lombiq.OSOCE.Samples.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="OrchardCore.Module.Targets" Version="2.0.0-preview-18312" />
<PackageReference Include="OrchardCore.ContentManagement" Version="2.0.0-preview-18312" />
<PackageReference Include="OrchardCore.ContentTypes.Abstractions" Version="2.0.0-preview-18312" />
<PackageReference Include="OrchardCore.DisplayManagement" Version="2.0.0-preview-18312" />
<PackageReference Include="OrchardCore.Module.Targets" Version="2.0.0-preview-18315" />
<PackageReference Include="OrchardCore.ContentManagement" Version="2.0.0-preview-18315" />
<PackageReference Include="OrchardCore.ContentTypes.Abstractions" Version="2.0.0-preview-18315" />
<PackageReference Include="OrchardCore.DisplayManagement" Version="2.0.0-preview-18315" />
</ItemGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion src/Modules/Lombiq.UIKit
2 changes: 1 addition & 1 deletion src/Utilities/Lombiq.SetupExtensions
Original file line number Diff line number Diff line change
Expand Up @@ -29,5 +29,7 @@ public Task VerifyHomePageAndLayout() =>
context => context.AssertVisualVerificationApprovedOnAllResolutionsWithPlatformSuffix(
_visualVerificationSizes,
_ => By.TagName("body"),
pixelErrorPercentageThreshold: 0.005));
// Chrome can have rendering differences among GitHub Actions runner types, so to not break CI builds,
// allowing a larger threshold.
pixelErrorPercentageThreshold: 0.016));
}
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.