-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: settings page #260
feat: settings page #260
Conversation
308d9be
to
39c59ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code:
Overall, not much. Lots of tiny little things. Take a look at the specific comments for more info. Couple rogue comments (I didn't notate all), not sure about initSettings.
UI:
Responsive design has a bit to be desired...
Switch feels way too big—although I know that's not the purpose of this PR, maybe we can get one of the new devs on it?
Lots of other little minor UI things, I'll let Isaiah handle those.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
What else is going for the Developer Mode section? Is that a separate PR and will be finished before release?
-
The title (UTRP SETTINGS & CREDITS PAGE) and UTRP logo and divider are too small. Please scale it exactly how it is scaled in Calendar view. (Settings' header and Calendar's header should basically be identical sizes)
-
The headers' text (ex: ADVANCED SETTINGS, Developer Mode, LONGHORN DEVELOPERS ADMINS, UTRP CONTRIBUTERS) should be color UTRP Black (#1A2024)
The description text under each header should be Primary Color (UT) Black (#333F48)
The contributor "Contributor" text should also be Primary Color (UT) Black (#333F48)
Rev 1
Rev 2
This change is
This change is