Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: settings page #260

Merged
merged 24 commits into from
Oct 10, 2024
Merged

feat: settings page #260

merged 24 commits into from
Oct 10, 2024

Conversation

doprz
Copy link
Collaborator

@doprz doprz commented Oct 3, 2024

Rev 1
image

Rev 2
image

This change is Reviewable


This change is Reviewable

@doprz doprz self-assigned this Oct 3, 2024
@doprz doprz marked this pull request as draft October 3, 2024 17:45
@doprz doprz marked this pull request as ready for review October 5, 2024 23:05
@doprz doprz requested review from sghsri, Razboy20 and IsaDavRod October 5, 2024 23:05
@doprz doprz added ready-for-review UI/UX-figma PRs that fulfill a task on the UI/UX & Feature Roadmap labels Oct 6, 2024
@doprz doprz force-pushed the feature/settings-page branch from 308d9be to 39c59ff Compare October 7, 2024 00:25
src/assets/LD-icon.png Outdated Show resolved Hide resolved
Copy link
Member

@Razboy20 Razboy20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code:
Overall, not much. Lots of tiny little things. Take a look at the specific comments for more info. Couple rogue comments (I didn't notate all), not sure about initSettings.

UI:
Responsive design has a bit to be desired...

image

Switch feels way too big—although I know that's not the purpose of this PR, maybe we can get one of the new devs on it?

Lots of other little minor UI things, I'll let Isaiah handle those.

src/pages/calendar/CalendarMain.tsx Show resolved Hide resolved
src/shared/storage/OptionsStore.ts Show resolved Hide resolved
src/views/components/PopupMain.tsx Show resolved Hide resolved
src/views/components/common/SwitchButton.tsx Show resolved Hide resolved
src/views/components/settings/Preview.tsx Outdated Show resolved Hide resolved
src/views/hooks/useGitHubStats.ts Outdated Show resolved Hide resolved
@doprz doprz requested a review from Razboy20 October 9, 2024 03:15
@doprz doprz merged commit 7a5c3a2 into main Oct 10, 2024
14 checks passed
@doprz doprz deleted the feature/settings-page branch October 10, 2024 23:05
Copy link
Member

@IsaDavRod IsaDavRod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. What else is going for the Developer Mode section? Is that a separate PR and will be finished before release?

  2. The title (UTRP SETTINGS & CREDITS PAGE) and UTRP logo and divider are too small. Please scale it exactly how it is scaled in Calendar view. (Settings' header and Calendar's header should basically be identical sizes)

  3. The headers' text (ex: ADVANCED SETTINGS, Developer Mode, LONGHORN DEVELOPERS ADMINS, UTRP CONTRIBUTERS) should be color UTRP Black (#1A2024)

The description text under each header should be Primary Color (UT) Black (#333F48)

The contributor "Contributor" text should also be Primary Color (UT) Black (#333F48)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature ready-for-review UI/UX-figma PRs that fulfill a task on the UI/UX & Feature Roadmap utrp-v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants