Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): unhid settings button #288

Merged
merged 1 commit into from
Oct 11, 2024
Merged

fix(ui): unhid settings button #288

merged 1 commit into from
Oct 11, 2024

Conversation

yahya-kousa
Copy link
Contributor

@yahya-kousa yahya-kousa commented Oct 8, 2024 •
edited by Razboy20
Loading

This change is Reviewable

This change is Reviewable

This change is Reviewable

This change is Reviewable

This change is Reviewable

@Razboy20
Copy link
Member

Razboy20 commented Oct 8, 2024

This will be resolved by #260. (Sorry!)

@Razboy20 Razboy20 closed this Oct 8, 2024
@Razboy20
Copy link
Member

Razboy20 commented Oct 8, 2024

Actually just realized this is on calendar, and #260 doesn't uncomment out the settings buttons (although it should)

@Razboy20 Razboy20 reopened this Oct 8, 2024
@Razboy20 Razboy20 added blocked Do not merge (yet) feature labels Oct 8, 2024
doprz
doprz approved these changes Oct 11, 2024
View reviewed changes
Copy link
Collaborator

@doprz doprz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doprz doprz merged commit db1eac3 into Longhorn-Developers:main Oct 11, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doprz doprz doprz approved these changes

@Razboy20 Razboy20 Razboy20 approved these changes

Assignees
No one assigned
Labels
blocked Do not merge (yet) feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yahya-kousa @Razboy20 @doprz