Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Maintainability #386

Merged
merged 1 commit into from
Jan 4, 2023

Conversation

ppuetsch
Copy link
Contributor

@ppuetsch ppuetsch commented Jan 2, 2023

This PR

  • consistently applies the same indentation (4 spaces) to all python files
  • applies black code formatting to all python files
  • checks for black code style violations in Github Actions
  • Bumps Workflows in Github Actions to get rid of Warnings
  • Cleans up the Workflows Yaml File
  • Resolves flake8 style issues in utils and jkbms python files
  • Introduced checks for flake8 or black findings in GH Actions

@ppuetsch ppuetsch force-pushed the improve_maintainability branch 3 times, most recently from f434402 to d2de078 Compare January 2, 2023 20:02
…Apply Black Code Formatting and include into GH Actions, Apply flake8 to utils and jkbms (and include in GH Actions)
@ppuetsch ppuetsch force-pushed the improve_maintainability branch from d2de078 to c3fb728 Compare January 2, 2023 20:02
@ppuetsch
Copy link
Contributor Author

ppuetsch commented Jan 3, 2023

Hi @Louisvdw ,
Thank you for your great project - I like it a lot.
Please find in this PR some improvements concerning Code Formatting and the Usage of the CI. What do you think about it? If you like it, I will proceed on this path (e.g. add automated tests, get rid of CodeQL Warnings (and therewith re-enabling it) and so on.)

I am eager to receive your thoughts!

Best regards,
Philip

@Louisvdw
Copy link
Owner

Louisvdw commented Jan 4, 2023

Hi @ppuetsch
Thanks for the contribution. Hopefully I'll have some time to properly review it tonight.

It would be great to get some assistance with automations and fixing warnings.
I also planned on creating a build action for automatic releases, so if you want to have a look at that as well it would be a great help. (create_build.sh must be called in a linux enviroment like Ubuntu)

@ppuetsch
Copy link
Contributor Author

ppuetsch commented Jan 4, 2023

Hi @Louisvdw,

yes - I will be more than happy to assist with that.
Maybe we can create Issues so that we can align what to do / how to do. Or just leave me an E-Mail. :-)

Best regards,
Philip

@Louisvdw
Copy link
Owner

Louisvdw commented Jan 4, 2023

I prefer issues. It's just easier to manage.

@Louisvdw Louisvdw merged commit 049637d into Louisvdw:master Jan 4, 2023
@ppuetsch ppuetsch deleted the improve_maintainability branch January 4, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants