Make things configurable #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes to cell voltage, temp and version (cherry picked from commit 3b68ea6)
* automate release generation * make shell scripts +x * add yaml * rely on gh line ending conventions, simplify buildfiles.lst * add gitattributes * set file properties for run scripts to +x Co-authored-by: Philip Puetsch <[email protected]> (cherry picked from commit ce601fb)
# Conflicts: # etc/dbus-serialbattery/utils.py
Louisvdw
approved these changes
Jan 14, 2023
|
@ppuetsch would it be better, if the |
Sound good! |
|
Done #468. I added also missing descriptions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the configuration is back in - see
#389
#386
for previous discussions on that topic.
additionally, I made the bms_type configurable. If not set, behaviour is as before. But if configured, only the configured BMS will be tested. This will improve time-to-detection of the BMS after reoboot or deployment quite a bit.
I would suggest to update the documentation, in special the wiki, to reflect the changes here. A user is supposed to create a config.ini with his changes - maybe based on default_config.ini - but should NOT modify utils.py