Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropping support of php8.2 #2884

Merged
merged 3 commits into from
Jan 7, 2025
Merged

Dropping support of php8.2 #2884

merged 3 commits into from
Jan 7, 2025

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Jan 6, 2025 •
edited
Loading

That one is not going to make some people happy...

Especially the users of debian stable without the ondrej repo...

@codecov Codecov
Copy link

codecov bot commented Jan 6, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.06%. Comparing base (13de342) to head (4013042).
Report is 2 commits behind head on master.

Additional details and impacted files

@ildyria ildyria marked this pull request as ready for review January 6, 2025 22:42
@ildyria ildyria added the Review: easy Easy review expected: probably just need a quick to go through. label Jan 6, 2025
@ildyria ildyria added this to the 6.3 milestone Jan 6, 2025
@ildyria ildyria merged commit a692201 into master Jan 7, 2025
52 checks passed
@ildyria ildyria deleted the php8.3-php8.4 branch January 7, 2025 20:05
ildyria added a commit to sancsin/Lychee that referenced this pull request Jan 12, 2025
@ildyria
Dropping support of php8.2 (LycheeOrg#2884)
b93855c
@TwizzyDizzy
Copy link
Contributor

TwizzyDizzy commented Feb 15, 2025 •
edited
Loading

That one is not going to make some people happy...

Just here to agree with this statement. Just for general understanding on my part: what made that necessary at a time where 8.2 still has > 1.8 years of security support.

EDIT: ah. Your dependency update of slam/phpstan-extensions to version 6.5.0 made that necessary. That being said: the reason for their raise of the minimum version is not clear.

Cheers
Thomas

@Slamdunk
Copy link

That one is not going to make some people happy...

Especially the users of debian stable without the ondrej repo...

There are two PHP users that push to production:

  1. Those who use Docker, Ondrej's Debian repo or Remi's RPM repo
  2. And those who like to shoot themselves in the foot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d7415 d7415 d7415 approved these changes

@tinohager tinohager tinohager approved these changes

Assignees
No one assigned
Labels
Review: easy Easy review expected: probably just need a quick to go through.
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.
5 participants
@ildyria @TwizzyDizzy @Slamdunk @d7415 @tinohager