Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP 8.4 support, drop PHP 8.2 #61

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Add PHP 8.4 support, drop PHP 8.2 #61

merged 2 commits into from
Sep 25, 2024

Conversation

Slamdunk
Copy link
Owner

No description provided.

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.89%. Comparing base (7ae62f9) to head (8c454ac).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #61   +/-   ##
=========================================
  Coverage     97.89%   97.89%           
  Complexity      149      149           
=========================================
  Files            15       15           
  Lines           332      332           
=========================================
  Hits            325      325           
  Misses            7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Slamdunk Slamdunk merged commit dd0d6fd into master Sep 25, 2024
7 checks passed
@Slamdunk Slamdunk deleted the php_84 branch September 25, 2024 06:39
@TwizzyDizzy
Copy link

Hi there,

if you have the time and the inclination, I'd very much be interested in the reasons for dropping PHP 8.2 support at this point in time. At least it does not seem to be necessitated by your upstream dependencies... at least not from the PR at hand alone.

Appreciate any hint you can give.

Cheers
Thomas

@Slamdunk
Copy link
Owner Author

Because I maintain more than 20 libraries in my free time and for free, so I don't care about end users that don't update their systems.

@TwizzyDizzy
Copy link

TwizzyDizzy commented Feb 15, 2025

My question was neither offensive nor did it imply any kind of warranty or anything you ought to provide. It came from a genuine wish to understand. I know the place your rage is coming from, yet it was not called for.

so I don't care about end users that don't update their systems

That is your prerogative, even though you are wrong. It seems, though, that any kind of dialogue is not wanted here, so only thing left for me to do is say: have a nice day.

EDIT: I need to correct myself: you are not wrong in the sense that PHP 8.2 does not receive active support anymore. It does receive security support though, so you are wrong in the remark regarding people not updating their systems. That being said though, that is the eco-system we're currently living in and neither you or me are gonna fix this right here, right now.

Cheers
Thomas

@Slamdunk
Copy link
Owner Author

I'm european, words don't offend me, and I don't see any rage word in my statement.

Any dialoge that involves unsupported systems needs money to flow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants