Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Monica's changes for test PR #384

Closed
wants to merge 3 commits into from
Closed

Adds Monica's changes for test PR #384

wants to merge 3 commits into from

Conversation

jbteves
Copy link
Collaborator

@jbteves jbteves commented Aug 16, 2019

Closes None

Changes proposed in this pull request:
Applies Monica's patches to try and figure out what's happening in codecov; don't review or merge, please.

@jbteves
Copy link
Collaborator Author

jbteves commented Aug 16, 2019

Ugh, this is the wrong set of changes. Let me try again.

@codecov
Copy link

codecov bot commented Aug 16, 2019

Codecov Report

Merging #384 into master will increase coverage by 0.2%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #384     +/-   ##
=========================================
+ Coverage   79.74%   79.94%   +0.2%     
=========================================
  Files          40       40             
  Lines        2236     2259     +23     
=========================================
+ Hits         1783     1806     +23     
  Misses        453      453
Impacted Files Coverage Δ
tedana/tests/test_stats_computefeats2.py 100% <100%> (ø) ⬆️
tedana/tests/test_stats_get_coeffs.py 100% <100%> (ø) ⬆️
tedana/tests/test_stats_getfbounds.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f75d6fa...43eb38b. Read the comment docs.

@emdupre
Copy link
Member

emdupre commented Sep 6, 2019

Closing as a duplicate of #386. If that's not correct, @jbteves , please re-open !

@emdupre emdupre closed this Sep 6, 2019
@jbteves jbteves deleted the JT_check_tests branch September 13, 2019 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants