Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TST] Additional smoke tests for stats.py #386

Merged
merged 7 commits into from
Sep 6, 2019

Conversation

monicayao
Copy link
Contributor

Addresses #376 .
Replica of PR#378, where codedev decreased coverage somehow

Changes proposed in this pull request:

  • Compared to last time, I have synced my master up to date with the current tedana
  • I added the code directly on Github instead of on my IDE (which may have caused some issue)

Copy link
Collaborator

@jbteves jbteves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @monicayao !

@jbteves
Copy link
Collaborator

jbteves commented Aug 31, 2019

Wait, now we have no codecov at all...

@emdupre
Copy link
Member

emdupre commented Sep 6, 2019

The failure to show coverage is a more general problem with our CircleCI config. We're getting this error at coverage upload:

#!/bin/bash -eo pipefail
curl -s https://codecov.io/bash | bash -s -- \
  -f "/tmp/src/coverage/coverage.xml" \
  -t "${CODECOV_TOKEN}" \
  -n "${CIRCLE_BUILD_NUM}" \
  -y ".codecov.yml" \
  -F "" \
  -Z || echo 'Codecov upload failed'

/bin/bash: curl: command not found
Codecov upload failed

I'm going to go ahead and merge this, since a previous PR showed increased coverage.

Thanks, @monicayao and @jbteves !

@emdupre emdupre merged commit 5a8707d into ME-ICA:master Sep 6, 2019
@jbteves
Copy link
Collaborator

jbteves commented Sep 10, 2019

@all-contributors please add @monicayao for testing

@allcontributors
Copy link
Contributor

@jbteves

I've put up a pull request to add @monicayao! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants