-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TST] Additional smoke tests for stats.py #386
Conversation
Update to sync
Through github (hopefully no error)
Through github, hopefully pass the integration test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @monicayao !
Wait, now we have no codecov at all... |
The failure to show coverage is a more general problem with our CircleCI config. We're getting this error at coverage upload:
I'm going to go ahead and merge this, since a previous PR showed increased coverage. Thanks, @monicayao and @jbteves ! |
@all-contributors please add @monicayao for testing |
I've put up a pull request to add @monicayao! 🎉 |
Addresses #376 .
Replica of PR#378, where codedev decreased coverage somehow
Changes proposed in this pull request: