Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Optimize flamechart][3/4] Rename flame graph -> flame chart #92

Merged
merged 1 commit into from
Jul 29, 2020

Conversation

taneliang
Copy link
Member

@taneliang taneliang commented Jul 28, 2020

Stack PR by STACK ATTACK:

@vercel
Copy link

vercel bot commented Jul 28, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/mlh-fellowship/scheduling-profiler-prototype/ggir0e1aq
✅ Preview: https://scheduling-profiler-prototype-git-0f8a7-3.mlh-fellowship.vercel.app

Copy link
Member

@kartikcho kartikcho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any specific reason to rename?

@taneliang
Copy link
Member Author

For correctness. Our visualization is a flame chart, not a flame graph.

Sources:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants