OD-17689 submodule xapi-proto add gpid to ImpExt_rp #10
Conversation
| @@ -138,6 +138,13 @@ message ImpExt { | |||
|
|
|||
| // Floor data used to synthesize RTB rules. | |||
| repeated Floor floors = 9; | |||
|
|
|||
| // OD-17689 GPID needs to be handled by ImpExt_rp | |||
There was a problem hiding this comment.
Our internal tickets shouldn't be mentioned in the documentation
| // to all participants in buying impressions for this placement. In general, | ||
| // this field will be populated with one of the DFP Ad Unit Code, Prebid Ad Slot, | ||
| // or value provided by the publisher or ad server. |
There was a problem hiding this comment.
This phrasing doesn't really make sense to me. It seems like it's talking about us populating it? This is for the incoming bid request, not something we have any control over—the value would always be populated by the publisher/ad server.
There was a problem hiding this comment.
Duplicated the comment from the original gpid schema definition:
https://github.com/MagniteEngineering/xapi-proto/blob/22f50d93da9478306897702878586385073c214e/src/proto/com/magnite/openrtb/v2/openrtb-xapi.proto#LL154C1-L154C1
I feel we should keep them the same for consistency. Do you think they should be updated or maintained as-is?
There was a problem hiding this comment.
Ah, didn't realize that. I guess that's ok then. I'd still suggest maybe changing in both comments "will" to "should" and "value" to "some value." The original PR (#4) has more context on the intention.
https://magnite.atlassian.net/browse/OD-17689