OD-12994: DFP ad unit code #4
Conversation
| @@ -150,6 +150,9 @@ message ImpExt { | |||
| // Supported viewability vendors. For list of supported vendors, visit: | |||
| // https://resources.rubiconproject.com/resource/publisher-resources/xapi-specifications/#4.9. | |||
| repeated string viewabilityvendors = 3; | |||
|
|
|||
| // Ad unit code. | |||
There was a problem hiding this comment.
Please update the comment to something like: Global Placement ID, as defined by TheTradeDesk. The goal is that all participants in buying impressions for the same placement get the same identifier, and that the identifier (as much as possible) is unique for the placement. (In general, this field will be populated with one of the DFP Ad Unit Code, Prebid Ad Slot, or some value provided by the publisher or ad server.)
| @@ -150,6 +150,12 @@ message ImpExt { | |||
| // Supported viewability vendors. For list of supported vendors, visit: | |||
| // https://resources.rubiconproject.com/resource/publisher-resources/xapi-specifications/#4.9. | |||
| repeated string viewabilityvendors = 3; | |||
|
|
|||
| // Global Placement ID. The unique identifier of the placement, that is sent | |||
There was a problem hiding this comment.
Should be no comma after "placement"
the placement that is sent
| @@ -150,6 +150,12 @@ message ImpExt { | |||
| // Supported viewability vendors. For list of supported vendors, visit: | |||
| // https://resources.rubiconproject.com/resource/publisher-resources/xapi-specifications/#4.9. | |||
| repeated string viewabilityvendors = 3; | |||
|
|
|||
| // Global Placement ID. The unique identifier of the placement, that is sent | |||
| // to all participants in buying impressions for this placement (in general, | |||
There was a problem hiding this comment.
Parenthesis should be the start of a new sentence
for this placement. (In general,
| // Global Placement ID. The unique identifier of the placement, that is sent | ||
| // to all participants in buying impressions for this placement (in general, | ||
| // this field will be populated with one of the DFP Ad Unit Code, Prebid Ad Slot, | ||
| // or value, provided by the publisher or ad server). |
There was a problem hiding this comment.
Should be no comma after value
// or value provided by
Added field for DFP ad unit code and GPID propagation