Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh Configuration Script Sources action #14714

Merged
merged 3 commits into from
Apr 11, 2017
Merged

Refresh Configuration Script Sources action #14714

merged 3 commits into from
Apr 11, 2017

Conversation

jntullo
Copy link

@jntullo jntullo commented Apr 10, 2017

Refresh action for configuration script sources collection and resource

POST /api/configuration_script_sources/:id
{
  "action": "refresh"
}
POST /api/configuration_script_sources
{
  "action":"refresh",
  "resources" : [ { "id" : id }, { "id" : id } ]
}

@miq-bot add_label enhancement, api
@miq-bot assign @abellotti

cc: @durandom @jameswnl @dclarizio @gmcculloug

config/api.yml Outdated
@@ -621,6 +621,8 @@
:identifier: embedded_configuration_script_source_delete
- :name: create
:identifier: embedded_configuration_script_source_add
- :name: refresh
:identifier: embedded_configuration_script_source_edit
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dclarizio which product features should be used for refresh? There are a bunch of them out there, wasn't sure which one made sense here.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jntullo is this what you're looking for? #14664

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dclarizio exactly what I was looking for 😄 thanks!

@jntullo
Copy link
Author

jntullo commented Apr 10, 2017

cc: @mzazrivec

@abellotti
Copy link
Member

@jntullo for multiple tasks in response, see #14404
I'd still want task_id/task_href referencing the first for compatibility, but tasks, an array of id and href hash, the client can then build the Task resource objects for each. Thanks.

@miq-bot
Copy link
Member

miq-bot commented Apr 10, 2017

Checked commits jntullo/manageiq@07f7621~...3f8c190 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
3 files checked, 0 offenses detected
Everything looks good. 🍪

@abellotti
Copy link
Member

LGTM @jntullo 👍 Thanks for updating the tasks signature in action results.

/cc @dclarizio @mzazrivec ok by you ?

@mzazrivec
Copy link
Contributor

LGTM.

@abellotti abellotti added this to the Sprint 59 Ending Apr 24, 2017 milestone Apr 11, 2017
@abellotti abellotti merged commit e284b35 into ManageIQ:master Apr 11, 2017
@jntullo jntullo deleted the enhancement/project_refresh branch April 11, 2017 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants