Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentications refresh action #14717

Merged
merged 1 commit into from
Apr 18, 2017
Merged

Authentications refresh action #14717

merged 1 commit into from
Apr 18, 2017

Conversation

jntullo
Copy link

@jntullo jntullo commented Apr 10, 2017

Refresh authentications action

POST /api/authentications/:id
{
  "action": "refresh"
}
POST /api/authentications
{
  "action":"refresh",
  "resources" [{ "id": :id }, {"id": id}]
}

@miq-bot add_label enhancement, api, wip, fine/yes
@miq-bot assign @abellotti

dependent on #14714

@abellotti
Copy link
Member

do we need to expose "refresh" action to authentications when accessed as subcollection ? i.e.

/api/configuration_script_payloads/:id/authentications/:a_id      (single)
/api/configuration_script_payloads/:id/authentications            (bulk)

@jntullo
Copy link
Author

jntullo commented Apr 10, 2017

@abellotti : @dclarizio or @mzazrivec would probably be the ones to answer that.

If so, I will do a follow-up PR

@dclarizio
Copy link

@abellotti @jntullo

do we need to expose "refresh" action to authentications when accessed as subcollection ?

This should be the same as providers, where you can refresh one or more at a time, as far as I know.

@miq-bot
Copy link
Member

miq-bot commented Apr 11, 2017

Checked commit jntullo@4b4e854 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks good. ⭐

@jntullo jntullo changed the title [WIP] Authentications refresh action Authentications refresh action Apr 11, 2017
@jntullo
Copy link
Author

jntullo commented Apr 11, 2017

@miq-bot remove_label wip

@miq-bot miq-bot removed the wip label Apr 11, 2017
@abellotti
Copy link
Member

@jntullo I'm 👍 with this PR, however, for a fine/yes, I thought the PR supporting task_ids was not marked as such.

@jntullo
Copy link
Author

jntullo commented Apr 13, 2017

@abellotti that was an oversight on my part. However, neither may be necessary now - @mzazrivec mentioned that where the refresh needs to use rails and not the API. Will this be changing and is the API needed?

@abellotti
Copy link
Member

ping @mzazrivec is this needed for Fine ? dependent PRs are only on master.

@mzazrivec
Copy link
Contributor

@abellotti Having this in fine would be certainly nice, but it's not necessary for
implementing button for targeted ansible refresh.

@abellotti
Copy link
Member

👍

@abellotti abellotti merged commit 23b5f69 into ManageIQ:master Apr 18, 2017
@abellotti abellotti added this to the Sprint 59 Ending Apr 24, 2017 milestone Apr 18, 2017
@jntullo jntullo deleted the enhancement/authentication_refresh branch November 28, 2017 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants