Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate Old Poseidon Hash #168

Merged
merged 11 commits into from
Jul 14, 2022
Merged

Deprecate Old Poseidon Hash #168

merged 11 commits into from
Jul 14, 2022

Conversation

BoyuanFeng
Copy link
Contributor

@BoyuanFeng BoyuanFeng commented Jul 12, 2022 •
edited by bhgomes
Loading

This PR is reverted by #186 and removes the CHANGELOG entry for this PR.

This PR deprecates old Poseidon hash in compat.rs and uses an updated Poseidon hash.

Note: Compatibility test is temporarily disabled. It will be recovered when new circuit is ready.

Closes: #117

Before we can merge this PR, please make sure that all the following items have been checked off:

  • Linked to an issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one line describing your change in CHANGELOG.md and added the appropriate changelog label to the PR.
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Checked that changes and commits conform to the standards outlined in CONTRIBUTING.md.

@BoyuanFeng BoyuanFeng marked this pull request as draft July 12, 2022 01:18
@BoyuanFeng BoyuanFeng added A-cryptography Area: Issues and PRs related to Cryptography changelog:added Changelog: add these changes to the `added` section of the changelog labels Jul 13, 2022
@BoyuanFeng BoyuanFeng self-assigned this Jul 13, 2022
@BoyuanFeng BoyuanFeng added this to the v0.6.0 milestone Jul 13, 2022
@BoyuanFeng BoyuanFeng marked this pull request as ready for review July 13, 2022 03:36
@BoyuanFeng BoyuanFeng requested review from bhgomes and tsunrise July 13, 2022 03:36
bhgomes
bhgomes suggested changes Jul 13, 2022
View reviewed changes
manta-pay/src/crypto/poseidon/hash.rs Outdated Show resolved Hide resolved
manta-pay/src/crypto/poseidon/hash.rs Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
tsunrise
tsunrise suggested changes Jul 13, 2022
View reviewed changes
manta-pay/src/crypto/poseidon/hash.rs Outdated Show resolved Hide resolved
manta-pay/src/crypto/poseidon/hash.rs Outdated Show resolved Hide resolved
manta-pay/src/crypto/poseidon/hash.rs Outdated Show resolved Hide resolved
tsunrise
tsunrise previously approved these changes Jul 14, 2022
View reviewed changes
@bhgomes bhgomes added changelog:removed Changelog: add these changes to the `removed` section of the changelog and removed changelog:added Changelog: add these changes to the `added` section of the changelog labels Jul 14, 2022
bhgomes
bhgomes suggested changes Jul 14, 2022
View reviewed changes
manta-pay/src/crypto/poseidon/hash.rs Outdated Show resolved Hide resolved
@tsunrise tsunrise dismissed their stale review July 14, 2022 08:53

yes, I also think we still need the ARITY check

@tsunrise tsunrise self-requested a review July 14, 2022 08:54
@bhgomes
Copy link
Contributor

bhgomes commented Jul 14, 2022

@BoyuanFeng we also need to remove the compat from the README.md.

@bhgomes bhgomes self-requested a review July 14, 2022 16:00
@bhgomes
Copy link
Contributor

bhgomes commented Jul 14, 2022 •
edited
Loading

CI issues could be related to this: rust-lang/rustup#3029

@bhgomes bhgomes merged commit 031daac into main Jul 14, 2022
@bhgomes bhgomes deleted the feat/deprecate-old-poseidon branch July 14, 2022 19:33
@bhgomes bhgomes mentioned this pull request Jul 14, 2022
Closed
@BoyuanFeng BoyuanFeng added changelog:skip Changelog: skip adding these changes to the changelog and removed changelog:removed Changelog: add these changes to the `removed` section of the changelog labels Jul 28, 2022
@bhgomes bhgomes mentioned this pull request Jul 28, 2022
Merged
6 tasks
@SupremoUGH SupremoUGH mentioned this pull request Aug 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsunrise tsunrise tsunrise approved these changes

@bhgomes bhgomes bhgomes approved these changes

Assignees

@BoyuanFeng BoyuanFeng

Labels
A-cryptography Area: Issues and PRs related to Cryptography changelog:skip Changelog: skip adding these changes to the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Delete Old Poseidon
3 participants
@BoyuanFeng @bhgomes @tsunrise