Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: recover compat poseidon #186

Merged
merged 9 commits into from
Jul 28, 2022
Merged

feat: recover compat poseidon #186

merged 9 commits into from
Jul 28, 2022

Conversation

BoyuanFeng
Copy link
Contributor

@BoyuanFeng BoyuanFeng commented Jul 28, 2022 •
edited by bhgomes
Loading

This PR is labeled skip because it removes a CHANGELOG entry from #168.

Before we can merge this PR, please make sure that all the following items have been checked off:

  • Linked to an issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one line describing your change in CHANGELOG.md and added the appropriate changelog label to the PR.
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Checked that changes and commits conform to the standards outlined in CONTRIBUTING.md.

@BoyuanFeng BoyuanFeng self-assigned this Jul 28, 2022
@BoyuanFeng BoyuanFeng added changelog:skip Changelog: skip adding these changes to the changelog A-cryptography Area: Issues and PRs related to Cryptography labels Jul 28, 2022
@BoyuanFeng BoyuanFeng added this to the v0.5.4 milestone Jul 28, 2022
@BoyuanFeng BoyuanFeng requested review from bhgomes and tsunrise July 28, 2022 16:17
@bhgomes bhgomes mentioned this pull request Jul 28, 2022
Merged
4 tasks
tsunrise
tsunrise previously approved these changes Jul 28, 2022
View reviewed changes
@bhgomes
chore: pin syn version in manta-pay
e42d978 
Signed-off-by: Brandon H. Gomes <[email protected]>
bhgomes
bhgomes previously approved these changes Jul 28, 2022
View reviewed changes
tsunrise
tsunrise previously approved these changes Jul 28, 2022
View reviewed changes
@bhgomes
chore: disable hakari
dbea6ef 
Signed-off-by: Brandon H. Gomes <[email protected]>
@bhgomes bhgomes dismissed stale reviews from tsunrise and themself via dbea6ef July 28, 2022 17:10
@tsunrise tsunrise self-requested a review July 28, 2022 17:15
bhgomes added 2 commits July 28, 2022 18:26
@bhgomes
feat: disable hakari on the CI on the main branch
8aef3b1 
Signed-off-by: Brandon H. Gomes <[email protected]>
@bhgomes
chore: enable hakari
b150ad0 
Signed-off-by: Brandon H. Gomes <[email protected]>
@bhgomes bhgomes requested review from tsunrise and bhgomes July 28, 2022 17:28
bhgomes
bhgomes previously approved these changes Jul 28, 2022
View reviewed changes
@bhgomes
chore: fix typo in CI
c45f7df 
Signed-off-by: Brandon H. Gomes <[email protected]>
@bhgomes bhgomes self-requested a review July 28, 2022 17:34
bhgomes
bhgomes previously approved these changes Jul 28, 2022
View reviewed changes
@bhgomes bhgomes merged commit d8d5862 into main Jul 28, 2022
@bhgomes bhgomes deleted the feat/recover-compat-poseidon branch July 28, 2022 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsunrise tsunrise tsunrise approved these changes

@bhgomes bhgomes bhgomes approved these changes

Assignees

@BoyuanFeng BoyuanFeng

Labels
A-cryptography Area: Issues and PRs related to Cryptography changelog:skip Changelog: skip adding these changes to the changelog
Projects
None yet
Milestone
v0.5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@BoyuanFeng @bhgomes @tsunrise