Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show bootscreen later #4032

Merged
merged 1 commit into from
Jun 14, 2016
Merged

Show bootscreen later #4032

merged 1 commit into from
Jun 14, 2016

Conversation

AnHardt
Copy link
Contributor

@AnHardt AnHardt commented Jun 14, 2016

Init display and show bootscreen later, but init display in kill()
to init outputs before the bootscreen delays, but being able to display
kill errors.

Fix for #3973 (pin state at splashscreen)

@AnHardt
Show bootscreen later
b4fedec 
Init display and show bootscreen later, but init display in `kill()`
to init outputs before the bootscreen delays but being able to display
kill errors.
thinkyhead
thinkyhead reviewed Jun 14, 2016
View reviewed changes
Marlin/Marlin_main.cpp
delay(1000);
#elif ENABLED(ULTRA_LCD)
bootscreen();
lcd_init();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Calling lcd_init a second time here is intentional?

Copy link
Contributor Author

@AnHardt AnHardt Jun 14, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It's needed to restore the custom charset. Does not really hurt. We are not printing then.

@AnHardt AnHardt mentioned this pull request Jun 14, 2016
Closed
@thinkyhead thinkyhead merged commit b708196 into MarlinFirmware:RCBugFix Jun 14, 2016
@AnHardt AnHardt deleted the bootscreen-delay branch June 14, 2016 01:47
AnHardt added a commit to AnHardt/Marlin that referenced this pull request Jun 14, 2016
@AnHardt
Custom Splash Screen
02b3d6b 
Custom Splash Screen for full graphic displays.

Too complicated for the hitachis without knowing what exactly to display.

On top of MarlinFirmware#4032
Realisation of an idea from MarlinFirmware#3996
@ghost
Copy link

ghost commented Jun 14, 2016 •
edited by ghost
Loading

It seems that this PR has problem with REPRAP_DISCOUNT_SMART_CONTROLLER.
In case of MEGA2560 + RAMPS, orange LED of MEGA2560 and red LED of RAMPS keep flashing vehemently after uploading the sketch, and LCD doesn't show anything.
And, the whole access is rejected(from Arduino IDE, Repetier-Host, LCD encoder).
Even if I push the reset button on RAMPS ,LEDs flash again immediately, access is never accepted.
When RAMPS is separated from MEGA2560 physically, at last access is accepted.

When I revert this PR, it's no problem.

In case of REPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER, it's no problem whether this PR is reverted or not.

Configuration.h.txt
Configuration_adv.h.txt

@AnHardt
Copy link
Contributor Author

AnHardt commented Jun 14, 2016

Looks like a watchdog reset.
Did you change this delay?

    #if ENABLED(DOGLCD)
      delay(1000);
    #elif ENABLED(ULTRA_LCD)

@ghost
Copy link

ghost commented Jun 14, 2016 •
edited by ghost
Loading

Looks like a watchdog reset.

When I disable the USE_WATCHDOG, flashing doesn't occur and LCD works.
But it looks like that @characters of thermistor, "°", and heatbed are broken(replaced by something).
dscn1631
To supplement, If I into the menu by pushing a button of encoder then return to info-screen, broken characters are displayed normally for some reason.

Did you change this delay?

No, it isn't.
I didn't change anything.
This is a branch that it was used for test.
https://github.com/esenapaj/Marlin/tree/My-Micromake-Kossel-MEGA2560

@ghost
Copy link

ghost commented Jun 14, 2016

Um, it looks like that character of "FR" is also broken(replaced by clock? character)...

@AnHardt
Copy link
Contributor Author

AnHardt commented Jun 14, 2016

I can see the problem now - when SDSUPPORT is enabled.
Searching.

@AnHardt AnHardt restored the bootscreen-delay branch June 14, 2016 23:24
@AnHardt AnHardt mentioned this pull request Jun 14, 2016
Merged
@AnHardt
Copy link
Contributor Author

AnHardt commented Jun 15, 2016

With enabled SDSUPPORT and/or STRING_SPLASH_LINE2 the time between Initialisierung the watchdog and first heater update grew to high. Patch in #4043.

@AnHardt AnHardt deleted the bootscreen-delay branch June 15, 2016 00:14
@jbrazio jbrazio modified the milestone: 1.1.0 Jul 18, 2016
CONSULitAS pushed a commit to CONSULitAS/Marlin-K8200 that referenced this pull request Aug 18, 2016
@AnHardt
Custom Splash Screen
d14363a 
Custom Splash Screen for full graphic displays.

Too complicated for the hitachis without knowing what exactly to display.

On top of MarlinFirmware#4032
Realisation of an idea from MarlinFirmware#3996
@thinkyhead thinkyhead mentioned this pull request Nov 22, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: Improvement
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@AnHardt @thinkyhead @jbrazio