Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce safe_delay() #4043

Merged
merged 1 commit into from
Jun 16, 2016
Merged

Conversation

AnHardt
Copy link
Contributor

@AnHardt AnHardt commented Jun 14, 2016

Introduce safe_delay() for long delays what otherwise would cause
watchdog resets. Especially when added.

Explizit lcd_set_custom_characters(false) at the end of bootscreen().
Else the charset is not proper set in case of LCD_PROGRESS_BAR.

Follow up for #4032

@AnHardt
Copy link
Contributor Author

AnHardt commented Jun 14, 2016

Likely this is useful enough to give it a more prominent place. Marlin_main.cpp? temperature.cpp?

@AnHardt AnHardt mentioned this pull request Jun 15, 2016
@@ -443,6 +443,15 @@ unsigned lcd_print(char c) { return charset_mapper(c); }
lcd.setCursor(indent, 2); lcd.print('\x02'); lcd_printPGM(PSTR( "------" )); lcd.print('\x03');
}

void save_delay(uint16_t del){
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you mean "safe_delay."

@AnHardt AnHardt force-pushed the save_delay branch 2 times, most recently from 7fda58c to cec1b16 Compare June 15, 2016 07:05
@ghost
Copy link

ghost commented Jun 15, 2016

Thanks for the trying to fix.
Problem of LED flasing with USE_WATCHDOG has been solved.
But, problem of broken characters at first time is still alive...
About "FR", lower half part is replaced by "clock" ?

dscn1632

A branch that it was used for this test:
https://github.com/esenapaj/Marlin/tree/testes

@AnHardt
Copy link
Contributor Author

AnHardt commented Jun 15, 2016

@esenapaj
I hope i got it now.

Introduce save_delay() for long delays what otherwise would cause
watchdog resets

Explizit lcd_set_custom_characters(false) at the end of bootscreen().
Else the charset is not proper set in case of LCD_PROGRESS_BAR.
@ghost
Copy link

ghost commented Jun 15, 2016

Thanks for the updating.
Now problem is almost solved, but still bit alive.
Character of thermistor is OK, but "°" is broken (not always. It's extremely rare. < 5% per reset?).
dscn1634

"FR" is often broken(70~80% per reset?).
dscn1633

@AnHardt
Copy link
Contributor Author

AnHardt commented Jun 15, 2016

I can reproduce the problem occasionally. What we see is the upper half of the 'bed symbol' at the place the '°' should be. I have no idea how that can be.

@thinkyhead thinkyhead merged commit 948c467 into MarlinFirmware:RCBugFix Jun 16, 2016
@thinkyhead
Copy link
Member

What we see is the upper half of the 'bed symbol' at the place the '°' should be.

I have always seen custom character issues on the first boot. It fixes itself if you re-display the Info Screen. Maybe the custom character code is running early, when the display isn't ready.

@AnHardt AnHardt deleted the save_delay branch June 17, 2016 11:22
@thinkyhead thinkyhead changed the title Introduce save_delay() Introduce safe_delay() Jul 8, 2016
@thinkyhead thinkyhead mentioned this pull request Jul 8, 2016
@jbrazio jbrazio modified the milestone: 1.1.0 Jul 18, 2016
drewmoseley pushed a commit to drewmoseley/Marlin that referenced this pull request Nov 8, 2023
…aded_timeout

MK3: Set `Is filament loaded? Yes|No` default to `No` without a timeout.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants