python3Packages.dnspython: fix tests (again) #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is essentially the same fix as NixOS#161740, except not just for macOS. The `dnspython` build was failing on Linux with a certificate verification failure just like in NixOS#161740: ```ShellSession $ nix build nixpkgs#python3Packages.dnspython --rebuild error: builder for '/nix/store/c1v553fzq3yybsd0lm398qf87jmy47qd-python3.10-dnspython-2.3.0.drv' failed with exit code 1; last 10 log lines: > > /nix/store/iw1vmh509hcbby8dbpsaanbri4zsq7dj-python3-3.10.10/lib/python3.10/ssl.py:1342: SSLCertVerificationError … ``` … and this change fixes that build failure.
9999years
approved these changes
Feb 27, 2023
9999years
pushed a commit
that referenced
this pull request
Jun 8, 2023
This is essentially the same fix as NixOS#161740, except not just for macOS. The `dnspython` build was failing on Linux with a certificate verification failure just like in NixOS#161740: ```ShellSession $ nix build nixpkgs#python3Packages.dnspython --rebuild error: builder for '/nix/store/c1v553fzq3yybsd0lm398qf87jmy47qd-python3.10-dnspython-2.3.0.drv' failed with exit code 1; last 10 log lines: > > /nix/store/iw1vmh509hcbby8dbpsaanbri4zsq7dj-python3-3.10.10/lib/python3.10/ssl.py:1342: SSLCertVerificationError … ``` … and this change fixes that build failure.
wavewave
pushed a commit
that referenced
this pull request
Mar 12, 2024
This is essentially the same fix as NixOS#161740, except not just for macOS. The `dnspython` build was failing on Linux with a certificate verification failure just like in NixOS#161740: ```ShellSession $ nix build nixpkgs#python3Packages.dnspython --rebuild error: builder for '/nix/store/c1v553fzq3yybsd0lm398qf87jmy47qd-python3.10-dnspython-2.3.0.drv' failed with exit code 1; last 10 log lines: > > /nix/store/iw1vmh509hcbby8dbpsaanbri4zsq7dj-python3-3.10.10/lib/python3.10/ssl.py:1342: SSLCertVerificationError … ``` … and this change fixes that build failure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upstream PR is NixOS#218662
This is essentially the same fix as NixOS#161740, except not just for macOS.
The
dnspythonbuild was failing on Linux with a certificate verification failure just like in NixOS#161740:… and this change fixes that build failure.