python3Packages.dnspython: fix tests #161740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
bjornfor
reviewed
Feb 27, 2022
| ]; | ||
|
|
||
| disabledTests = [ | ||
| # dns.exception.SyntaxError: protocol not found | ||
| "test_misc_good_WKS_text" | ||
| # fails if IPv6 isn't available | ||
| "test_resolver_override" |
There was a problem hiding this comment.
Is this a darwin-only fix? I would have thought the build sandbox would prevent host IPv6 setup from being visible to the build?
There was a problem hiding this comment.
that sounds like the origin of the error.
Either way, this fixes an existing regression. We can explore alternatives in another PR.
13 tasks
13 tasks
6 tasks
Gabriella439
added a commit
to MercuryTechnologies/nixpkgs
that referenced
this pull request
Feb 27, 2023
This is essentially the same fix as NixOS#161740, except not just for macOS. The `dnspython` build was failing on Linux with a certificate verification failure just like in NixOS#161740: ```ShellSession $ nix build nixpkgs#python3Packages.dnspython --rebuild error: builder for '/nix/store/c1v553fzq3yybsd0lm398qf87jmy47qd-python3.10-dnspython-2.3.0.drv' failed with exit code 1; last 10 log lines: > > /nix/store/iw1vmh509hcbby8dbpsaanbri4zsq7dj-python3-3.10.10/lib/python3.10/ssl.py:1342: SSLCertVerificationError … ``` … and this change fixes that build failure.
Gabriella439
added a commit
to MercuryTechnologies/nixpkgs
that referenced
this pull request
Feb 27, 2023
This is essentially the same fix as NixOS#161740, except not just for macOS. The `dnspython` build was failing on Linux with a certificate verification failure just like in NixOS#161740: ```ShellSession $ nix build nixpkgs#python3Packages.dnspython --rebuild error: builder for '/nix/store/c1v553fzq3yybsd0lm398qf87jmy47qd-python3.10-dnspython-2.3.0.drv' failed with exit code 1; last 10 log lines: > > /nix/store/iw1vmh509hcbby8dbpsaanbri4zsq7dj-python3-3.10.10/lib/python3.10/ssl.py:1342: SSLCertVerificationError … ``` … and this change fixes that build failure.
Gabriella439
added a commit
that referenced
this pull request
Feb 27, 2023
This is essentially the same fix as #161740, except not just for macOS. The `dnspython` build was failing on Linux with a certificate verification failure just like in #161740: ```ShellSession $ nix build nixpkgs#python3Packages.dnspython --rebuild error: builder for '/nix/store/c1v553fzq3yybsd0lm398qf87jmy47qd-python3.10-dnspython-2.3.0.drv' failed with exit code 1; last 10 log lines: > > /nix/store/iw1vmh509hcbby8dbpsaanbri4zsq7dj-python3-3.10.10/lib/python3.10/ssl.py:1342: SSLCertVerificationError … ``` … and this change fixes that build failure.
9999years
pushed a commit
to MercuryTechnologies/nixpkgs
that referenced
this pull request
Jun 8, 2023
This is essentially the same fix as NixOS#161740, except not just for macOS. The `dnspython` build was failing on Linux with a certificate verification failure just like in NixOS#161740: ```ShellSession $ nix build nixpkgs#python3Packages.dnspython --rebuild error: builder for '/nix/store/c1v553fzq3yybsd0lm398qf87jmy47qd-python3.10-dnspython-2.3.0.drv' failed with exit code 1; last 10 log lines: > > /nix/store/iw1vmh509hcbby8dbpsaanbri4zsq7dj-python3-3.10.10/lib/python3.10/ssl.py:1342: SSLCertVerificationError … ``` … and this change fixes that build failure.
wavewave
pushed a commit
to MercuryTechnologies/nixpkgs
that referenced
this pull request
Mar 12, 2024
This is essentially the same fix as NixOS#161740, except not just for macOS. The `dnspython` build was failing on Linux with a certificate verification failure just like in NixOS#161740: ```ShellSession $ nix build nixpkgs#python3Packages.dnspython --rebuild error: builder for '/nix/store/c1v553fzq3yybsd0lm398qf87jmy47qd-python3.10-dnspython-2.3.0.drv' failed with exit code 1; last 10 log lines: > > /nix/store/iw1vmh509hcbby8dbpsaanbri4zsq7dj-python3-3.10.10/lib/python3.10/ssl.py:1342: SSLCertVerificationError … ``` … and this change fixes that build failure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Test on
x86_64-darwinandaarch64-darwinfail for me (and also seem to be failing on Hydra) with errors like, e.g.:Also, the network I'm on also doesn't support IPv6 which causes the
test_resolver_overridetest to fail.This PR fixes both those issues.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes