[Flask] RNTar Android native module for snaps installation #6300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
3 tasks
owencraston
force-pushed
the
snaps/android-npm-install
branch
from
7358076 to
604744e
Compare
owencraston
force-pushed
the
snaps/android-npm-install
branch
from
604744e to
c93da4d
Compare
owencraston
force-pushed
the
snaps/android-npm-install
branch
from
469e3cf to
0a95a9d
Compare
owencraston
changed the title
owencraston
commented
May 4, 2023
| * @param errorMessage - The error message to throw if validation fails. | ||
| */ | ||
| function validateSnapShasum(manifest, sourceCode, errorMessage = 'Invalid Snap manifest: manifest shasum does not match computed shasum.') { | ||
| - if (manifest.source.shasum !== getSnapSourceShasum(sourceCode)) { |
There was a problem hiding this comment.
I was unable to make this implementation work with the Shasum validation (the results are different on Android) so I am disabling it for now and will try to get it working in a future change. The issue to track this work can be found here.
owencraston
added
the
No QA Needed
There was a problem hiding this comment.
I only had a look at the java part.
It looks good overall, mostly comments with just one memory leak risk on the resource not closing: not sure there's reasons for leak to actually happen, but better using a try/finally or try with resource in case, who knows.
android/app/src/androidTest/java/com/metamask/nativeModules/RNTarTest/RNTarTest.java
Outdated
Show resolved
Hide resolved
android/app/src/androidTest/java/com/metamask/nativeModules/RNTarTest/RNTarTest.java
Show resolved
Hide resolved
android/app/src/androidTest/java/com/metamask/nativeModules/RNTarTest/RNTarTest.java
Outdated
Show resolved
Hide resolved
android/app/src/androidTest/java/com/metamask/nativeModules/RNTarTest/RNTarTest.java
Outdated
Show resolved
Hide resolved
android/app/src/main/java/io/metamask/nativeModules/RNTar/RNTar.java
Outdated
Show resolved
Hide resolved
android/app/src/main/java/io/metamask/nativeModules/RNTar/RNTar.java
Outdated
Show resolved
Hide resolved
android/app/src/main/java/io/metamask/nativeModules/RNTar/RNTar.java
Outdated
Show resolved
Hide resolved
android/app/src/main/java/io/metamask/nativeModules/RNTar/RNTar.java
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development & PR Process
release-xxlabel to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-reviewlabel when work is completedneeds-qalabel when dev review is completedQA Passedlabel when QA has signed offDescription
flaskbranch and will have failing tests. This is expected for now and we will address the failing tests (that also exist in the flask branch) as we get closer to a stable release.1. What is the reason for the change?
2. What is the improvement/solution?
.tgzfile (the type of file we get from NPM) and extracts its content to the device. We then pass the location of that extracted content to the snaps code and it reads it into the SnapsController.tgzcontent, I needed to install/use the Apache commons compress library into the Android project.Screenshots/Recordings
working.on.android.2.mov
Issue
Progresses https://github.com/MetaMask/mobile-planning/issues/731
Checklist