[Feature] Create custom detectSnapLocation to install Snap from NPM on Android #6052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
owencraston
force-pushed
the
decompress-snap-tarball-android
branch
2 times, most recently
from
c9ff240 to
9aafe26
Compare
owencraston
force-pushed
the
decompress-snap-tarball-android
branch
from
e01cb06 to
a079a27
Compare
owencraston
changed the base branch from
feat/snaps-system-integration
to
flask
This reverts commit 106523e.
…5923) * Local snaps install with controller version 0.26.2
… iOS (#5926) * Install a Snap From NPM iOS - Create NPMLocation class - Create a custom fetch function for the npm logic as we have slightly different logic - create a swift native module to read a .tgz file and decompress it - read the decompressed folder data and pass it to snaps - swiftlint
- extract icon from tar file - show request permissions for install snap and account access - move snap webview to the root of the app and make it invisible - create RPC method handlers to register snaps rpc methods
* swap for rn-fetch-blob * remove unused file
* Remove custom handlers and add PermissionMiddleware to SnapBridge RPC engine * exportMnemonic * Polyfill TextEncoder * slightly better UX * Add SnapMethodMiddleware to SnapBridge * fetch files based on manifest location * check source shasum --------- Co-authored-by: Gustavo Antunes <[email protected]>
owencraston
force-pushed
the
decompress-snap-tarball-android
branch
from
5310f32 to
8395f96
Compare
|
This branch got corrupted in a rebase so I am closing it in favour of #6300 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development & PR Process
release-xxlabel to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-reviewlabel when work is completedneeds-qalabel when dev review is completedQA Passedlabel when QA has signed offDescription
Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions,
1. What is the reason for the change?
2. What is the improvement/solution?
Screenshots/Recordings
If applicable, add screenshots and/or recordings to visualize the before and after of your change
Issue
Progresses https://github.com/MetaMask/mobile-planning/issues/731
Checklist