-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: RNTar native modules (Android and iOS) #7955
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #7955 +/- ##
==========================================
- Coverage 36.64% 36.61% -0.04%
==========================================
Files 1090 1092 +2
Lines 29113 29155 +42
Branches 2668 2670 +2
==========================================
+ Hits 10668 10674 +6
- Misses 17839 17875 +36
Partials 606 606 ☔ View full report in Codecov by Sentry. |
5d6d03e
to
fecc3f6
Compare
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2237b682-8368-4082-8dde-6f8231efc422 |
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/94969d5c-7eb1-4489-a642-7c7b43ed8ae9 |
app/components/Views/Snaps/SnapsSettingsList/SnapsSettingsList.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Left some comments
7c01e0a
to
ac12833
Compare
I created a QA build and confirmed that the new snaps settings page is in fact not in this build. |
ac12833
to
6f9ddff
Compare
app/components/Views/Snaps/SnapsSettingsList/SnapsSettingsList.tsx
Outdated
Show resolved
Hide resolved
6f9ddff
to
204c565
Compare
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0e392af7-948b-41b1-9a0a-66fde293cb66 |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just left a small nit
Description
This PR adds a custom native module RNTar. This module takes a file system path to a
.tgz
(tar gzip) file. The module reads this file, decompresses it and places it in the target directory. It then returns the new location of the decompressed data. This PR is needed for the mobile snaps implementation and will be used in this following PR.Most of the native code (java and swift) was implemented and reviewed in previous prs. This change is bringing them into main.
Related issues
Progresses: https://github.com/MetaMask/accounts-planning/issues/143
Manual testing steps
yarn setup
js.env
export METAMASK_BUILD_TYPE
toexport METAMASK_BUILD_TYPE="flask"
source .js.env
yarn watch:clean
Test RNTar
button.js.env
METAMASK_BUILD_TYPE
back tomain
source .js.env
yarn watch:clean
)Snaps
section should no longer be presentRunning android unit tests
RNTarTest.java
Screenshots/Recordings
After
720.copy.Screen.Recording.2023-11-29.at.11.20.20.PM.mov
Screen.Recording.2023-11-30.at.10.44.04.AM.mov
Pre-merge author checklist
Pre-merge reviewer checklist