This repository has been archived by the owner on Mar 13, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also fixes minor gripes i had while debugging
LordOfPolls
added
the
Improvement
Something that is already implemented but can be done better
label
Sep 4, 2022
LordOfPolls
requested review from
AstreaTSS,
Kigstn,
artem30801,
benwoo1110,
leestarb,
silasary,
Wolfhound905 and
zevaryx
September 4, 2022 16:38
Kigstn
approved these changes
Sep 4, 2022
* feat: add MENTION_SPAM enum value * feat: implement trigger class
* feat: get total retrieved from iterator * feat: use async iterator to speedup http chunking
silasary
approved these changes
Sep 5, 2022
AstreaTSS
approved these changes
Sep 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I literally forgot to review this as the bot I was using to test this didn't run into any errors or constant reconnects, and so it ran in the background quietly without me remembering.
I love this update already.
Kigstn
approved these changes
Sep 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-approving since changes happened
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of pull request is this?
Description
Merges dev into master
Rationale
It's quite early for a pypi release however #619 is affecting production bots. So im rushing this one out
Python 3.10.x