This repository has been archived by the owner on Mar 13, 2023. It is now read-only.
fix: fix usage of hybrid cmds with no localized names #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Polls did this because Discord was stupid - apologies this broke hybrid. Merging |
silasary
pushed a commit
that referenced
this pull request
Sep 13, 2022
* fix: fix usage of hybrid cmds with no localized names (#639) * fix: make naff always use the correct logger by converting const.logger into a function Co-authored-by: Astrea <[email protected]>
LordOfPolls
pushed a commit
that referenced
this pull request
Sep 14, 2022
* fix: fix usage of hybrid cmds with no localized names (#639) * fix: make naff always use the correct logger by converting const.logger into a function Co-authored-by: Astrea <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of pull request is this?
Description
Seems like Polls fixed Discord localization syncing by making
to_locale_dictreturnNoneif the there's no localization. This screwed over assumptions hybrid commands made, so this PR ensures that there will always be a dict to work with.Changes
to_locale_dictuseto_locale_dict() or {}for hybrid commands. This requires some ugly parenthesis, but otherwise works fine.Checklist
Python 3.10.x