This repository has been archived by the owner on Mar 13, 2023. It is now read-only.
fix💥: make naff always use the correct logger #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silasary
reviewed
Sep 13, 2022
Kigstn
changed the title
LordOfPolls
pushed a commit
that referenced
this pull request
Sep 14, 2022
* fix: fix usage of hybrid cmds with no localized names (#639) * fix: make naff always use the correct logger by converting const.logger into a function Co-authored-by: Astrea <[email protected]>
silasary
added a commit
that referenced
this pull request
Sep 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of pull request is this?
Description
Naff was not always using the correct logger. This was due to the logger being imported before the imported variable was changed on Client initialisation.
const.loggerhas been converted to a function which ensures the fetched object is the set one.Technically breaking if anyone imported and used the logger
Changes
const.loggerto a functionChecklist
Python 3.10.x