Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add smart defaults for evaporative coolers #1807

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Conversation

mdahlhausen
Copy link
Collaborator

@mdahlhausen mdahlhausen commented Sep 10, 2024

Pull request overview

Add smart defaults for evaporative cooler objects. This adds pumping energy, and slightly lowers water use.

Pull Request Author

  • Method changes or additions
  • Resolved yard documentation errors for new code (ran bundle exec rake doc)
  • Resolved rubocop syntax errors for new code (ran bundle exec rake rubocop)
  • All new and existing tests passes

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a code review on GitHub
  • All related changes have been implemented: method additions, changes, tests
  • Check rubocop errors
  • Check yard doc errors
  • If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • CI status: all green or justified

Add smart defaults for evaporative cooler objects.
This adds pumping energy, and slightly lowers water use.
@mdahlhausen mdahlhausen merged commit 2984e40 into master Sep 11, 2024
1 of 2 checks passed
@mdahlhausen mdahlhausen deleted the fix/issue892 branch September 11, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

evaporative coolers show no cooling
1 participant