Fix "generator didn't stop" update error for LPC55 devices #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daringer
requested review from
robin-nitrokey,
sosthene-nitrokey and
szszszsz
sosthene-nitrokey
approved these changes
Sep 21, 2023
robin-nitrokey
approved these changes
Sep 21, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the:
error by introducing a
time.sleep(1)directly after asking the device to boot into the bootloader so that udev has enough time to properly handle the new device.Checklist
Make sure to run
make checkandmake fixbefore creating a PR, otherwise the CI will fail.Test Environment and Execution
Fixes #394