Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "generator didn't stop" update error for LPC55 devices #446

Merged
merged 1 commit into from
Sep 25, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pynitrokey/nk3/updates.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
import logging
import platform
import re
import time
from abc import ABC, abstractmethod
from contextlib import contextmanager
from io import BytesIO
Expand Down Expand Up @@ -324,6 +325,9 @@ def _get_bootloader(self, device: Nitrokey3Base) -> Iterator[Nitrokey3Bootloader
"The reboot was not confirmed with the touch button"
)

# needed for udev to properly handle new device
time.sleep(1)

if platform.system() == "Darwin":
# Currently there is an issue with device enumeration after reboot on macOS, see
# <https://github.com/Nitrokey/pynitrokey/issues/145>. To avoid this issue, we
Expand Down