Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.httplib2: disable failing test #163703

Closed

Conversation

happysalada
Copy link
Contributor

Description of changes

Disabling a test that fails mysteriously on aarch64-darwin.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from fabaff March 11, 2022 21:09
@ofborg ofborg bot added 10.rebuild-darwin: 501+ 10.rebuild-darwin: 501-1000 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Mar 11, 2022
@malob
Copy link
Member

malob commented Mar 11, 2022

I'm pretty sure I addressed python3Packages.httplib2's build failure due to failing tests on darwin in #162257, and it wasn't the test_get_301_no_redirect that was the issue but, test_connection_close.

XFAIL tests/test_http.py::test_get_301_no_redirect
  FIXME: 301 cache works only with follow_redirects, should work regardless
XPASS tests/test_other.py::test_timeout_global FIXME: for unknown reason global timeout test fails in Python3 with response 200
FAILED tests/test_other.py::test_connection_close - ConnectionResetError: [Er...
= 1 failed, 478 passed, 8 skipped, 2 deselected, 1 xfailed, 1 xpassed in 9.32s =

@malob
Copy link
Member

malob commented Mar 11, 2022

@jonringer (or others), this build failure was fixed in #162257, along with the build failure for python3Packages.dnspython fixed in #161740 (both of which targeted staging) have resulted in those two packages being some of the most problematic dependencies right now for darwin users (see nix-review-tools reports for nixpkgs:trunk and nixpkgs:nixpkgs-unstable-aarch64-darwin) .

Do you have a sense for when those might hit master? If it's gonna be a while, could those fixes be moved over to master sooner than that? (Sorry if that's a noob question, I don't have much experience with the staging workflow.)

@happysalada
Copy link
Contributor Author

@malob thank you for your comment, looking at the error closer, it turns out you are right!
understood that the fix is on staging and waiting to make it onto unstable, Thank you!

@happysalada happysalada deleted the httplib2_disable_failing_test branch April 28, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants