Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure AD Login to AWS with AWS SAML #160

Closed
mholttech opened this issue Aug 26, 2021 · 2 comments · Fixed by #165
Closed

Azure AD Login to AWS with AWS SAML #160

mholttech opened this issue Aug 26, 2021 · 2 comments · Fixed by #165
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@mholttech
Copy link
Contributor

Is your feature request related to a problem? Please describe.
My company uses AzureAD to authenticate into AWS using SAML Authentication (Not AWS SSO). It does not appear that Leapp currently supports this. This is accomplished by logging into AWS using a AWS SAML URL like https://signin.aws.amazon.com/saml/AWS-ACCOUNT-1

Describe the solution you'd like
Would like to accomplish the login flow with Leapp.

Describe alternatives you've considered
We currently use https://github.com/sportradar/aws-azure-login for this and when it comes to CI/CD to access AWS and it works well, however it has proven to be a barrier for our developers.

@mholttech mholttech added the enhancement New feature or request label Aug 26, 2021
@mholttech mholttech changed the title Azure AD Login to AWS without AWS SSO Azure AD Login to AWS with AWS SAML Aug 26, 2021
@andreacavagna01
Copy link
Contributor

Hi, the issue refers to this specific use case:
https://docs.leapp.cloud/use-cases/aws_iam_role/#aws-iam-federated-role

at the moment we are not supporting Azure AD as Identity Provider, but it's a little addition to be made in order to make Azure AD working with Leapp.

As you can see in this pull request allowing Okta as an identity provider the only thing to be done is to add the correct filter for the SAML response of the callback on Azure AD here:

I can help you in doing this but at the moment I do have not an Azure AD account to test it and find the correct filter on the SAML response.

I'll add a Help needed label, since, when I found someone with this Identity provider in the community wanting to collaborate, we can implement this feature in some hours together

Also, I will add this enhancement in the roadmap.

@andreacavagna01 andreacavagna01 added the help wanted Extra attention is needed label Aug 27, 2021
@mholttech
Copy link
Contributor Author

mholttech commented Aug 30, 2021

Hey @andreacavagna01,

I'd be happy to work with you to find the correct filter for AzureAD.

edit: I just joined the slack team so you can find me there as well

mholttech added a commit to mholttech/leapp that referenced this issue Aug 30, 2021
This adds support for using AzureAD to Federate into AWS. Fixes Noovolari#160.
ericvilla added a commit that referenced this issue Sep 8, 2021
* feat: add support for aws azuread federation

This adds support for using AzureAD to Federate into AWS. Fixes #160.

* fix: added /oauth2/authorize presence check in AWS IAM Role Federated login window

* fix: sanitized untrusted URLs

Co-authored-by: Eric Villa <[email protected]>
ericvilla added a commit that referenced this issue Sep 30, 2021
* feat: add support for aws azuread federation

This adds support for using AzureAD to Federate into AWS. Fixes #160.

* fix: added /oauth2/authorize presence check in AWS IAM Role Federated login window

* fix: sanitized untrusted URLs

Co-authored-by: Eric Villa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants