-
-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for aws azuread federation #165
feat: add support for aws azuread federation #165
Conversation
This adds support for using AzureAD to Federate into AWS. Fixes Noovolari#160.
This pull request introduces 1 alert when merging 0a7ca2a into 00b89d7 - view on LGTM.com new alerts:
|
The full URL when authenticating is I'm not sure if this is something that can be wildcarded for or if this needs to be handled differently. |
Hi @mholttech, looking at this implementation, it seems the filters you've added fit how the needAuthentication method works. Basically, it is an addition to the current logic and does not interfere with it. |
I think the filter works but to further scope down I'd make a try with "https://login.microsoftonline.com/*/saml2" |
I just tried that with my dev build, unfortunately that appears to break the SAML Authentication |
Hi @mholttech! I've set up a federation between an AzureAD SAML Application and an AWS IAM Identity Provider. The solution works with your implementation, but it shows the login window every time you click to activate the session. The reason behind this behavior is that The very first call to login.microsoftonline.com host has the following template: https://login.microsoftonline.com/oauth2/authorize The condition now is Using this condition, Leapp does not show the login windows if you're already logged in. |
Hey @ericvilla, Thanks for the feedback. I'm updating the filter on my local build to validate on my end and then I'll update the PR |
This pull request introduces 1 alert when merging b8e2441 into fbcf00d - view on LGTM.com new alerts:
|
@ericvilla It looks good to me. Works as expected and no longer seeing the popup during credential refresh |
This pull request introduces 3 alerts when merging 47d0401 into fbcf00d - view on LGTM.com new alerts:
|
* feat: add support for aws azuread federation This adds support for using AzureAD to Federate into AWS. Fixes #160. * fix: added /oauth2/authorize presence check in AWS IAM Role Federated login window * fix: sanitized untrusted URLs Co-authored-by: Eric Villa <[email protected]>
This adds support for using AzureAD to Federate into AWS. Fixes #160.
Changelog