Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for aws azuread federation #165

Merged
merged 3 commits into from
Sep 8, 2021
Merged

feat: add support for aws azuread federation #165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0a7ca2a
feat: add support for aws azuread federation
mholttech Aug 30, 2021
b8e2441
fix: added /oauth2/authorize presence check in AWS IAM Role Federated…
ericvilla Sep 7, 2021
47d0401
fix: sanitized untrusted URLs
ericvilla Sep 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/use-cases/aws_iam_role.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# AWS IAM Roles

## AWS IAM Federated Role
Federation is established between **G Suite**, **Okta**, **OneLogin** and **AWS**. No more AWS credentials
Federation is established between **G Suite**, **Okta**, **OneLogin**, **AzureAD**, and **AWS**. No more AWS credentials
management is needed.

Leapp allows you to get to cloud resources with company email and password.
Expand Down
2 changes: 1 addition & 1 deletion docs/use-cases/intro.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,5 +21,5 @@ The use cases covered by Leapp are the following:
- **OneLogin to AWS** - :white_check_mark:
- **G Suite to Azure** - :white_check_mark:
- **AZURE AD to Azure** - :white_check_mark:
- **AZURE AD to AWS** - :soon:
- **AZURE AD to AWS** - :white_check_mark:
- **AWS Single Sign-On** - :white_check_mark:
10 changes: 8 additions & 2 deletions src/app/services/session/aws/methods/aws-iam-role-federated.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,7 @@ export class AwsIamRoleFederatedService extends AwsSessionService {
'https://*.onelogin.com/*',
'https://*.okta.com/*',
'https://accounts.google.com/ServiceLogin*',
'https://login.microsoftonline.com/*',
'https://signin.aws.amazon.com/saml'
]
};
Expand All @@ -172,7 +173,7 @@ export class AwsIamRoleFederatedService extends AwsSessionService {
// to construct the ideal method to deal with the construction of the response
idpWindow.webContents.session.webRequest.onBeforeRequest(filter, (details, callback) => {
// G Suite
if (details.url.indexOf('accounts.google.com/ServiceLogin') !== -1) {
if (details.url.indexOf('https://accounts.google.com/ServiceLogin') !== -1) {
idpWindow = null;
resolve(true);
}
Expand All @@ -186,8 +187,13 @@ export class AwsIamRoleFederatedService extends AwsSessionService {
idpWindow = null;
resolve(true);
}
// AzureAD
if (details.url.indexOf('https://login.microsoftonline.com') !== -1 && details.url.indexOf('/oauth2/authorize') !== -1) {
idpWindow = null;
resolve(true);
}
// Do not show window: already logged by means of session cookies
if (details.url.indexOf('signin.aws.amazon.com/saml') !== -1) {
if (details.url.indexOf('https://signin.aws.amazon.com/saml') !== -1) {
idpWindow = null;
resolve(false);
}
Expand Down