Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge build steps for multiple platforms #931

Merged
merged 3 commits into from
Dec 18, 2023
Merged

Merge build steps for multiple platforms #931

merged 3 commits into from
Dec 18, 2023

Conversation

aadnekar
Copy link
Contributor

No description provided.

@aadnekar aadnekar requested a review from a team as a code owner December 18, 2023 11:33
@aadnekar aadnekar changed the title GitHub actions Merge build steps for multiple platforms Dec 18, 2023
Copy link

@cybic cybic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Single small "would"-comment.
LGTM!

# build_on_mac_apple_silicon:
# uses: ./.github/workflows/build.yml
# with:
# runner: macos-latest-xlarge
# electronArgument:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

W: Formatting seems a bit off, but that could be the diff's fault.

@aadnekar aadnekar merged commit e3a9231 into main Dec 18, 2023
7 checks passed
@aadnekar aadnekar deleted the github-actions branch December 18, 2023 11:52
kylebonnici pushed a commit that referenced this pull request Feb 5, 2024
In order to have a single electron build step, utilize the workflow input.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants