Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge build steps for multiple platforms #931

Merged
merged 3 commits into from
Dec 18, 2023
Merged

Merge build steps for multiple platforms #931

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0125a76
Update build.yml
aadnekar Dec 18, 2023
cb8c911
call with electronArgument
aadnekar Dec 18, 2023
7e67f6a
Merge platform builds into single step
aadnekar Dec 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,15 +30,8 @@ jobs:
- name: Build for Production
run: npm run build:prod

- name: Run Electron Builder (Windows)
if: runner.os == 'Windows'
- name: Run Electron Builder
run: npx electron-builder -p never ${{ inputs.electronArgument }}
- name: Run Electron Builder (macOS)
if: runner.os == 'macOS'
run: npx electron-builder -p never --x64
- name: Run Electron Builder (Linux)
if: runner.os == 'Linux'
run: npx electron-builder -p never

- name: Publish built artifact
uses: actions/upload-artifact@v3
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,15 @@ jobs:
uses: ./.github/workflows/build.yml
with:
runner: ubuntu-latest
electronArgument: empty
electronArgument: ''

# build_on_mac_intel:
# uses: ./.github/workflows/build.yml
# with:
# runner: macos-latest
# electronArgument: --x64
# build_on_mac_apple_silicon:
# uses: ./.github/workflows/build.yml
# with:
# runner: macos-latest-xlarge
# electronArgument:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

W: Formatting seems a bit off, but that could be the diff's fault.