fix(recall): #MZI-216 update recall admin's rights #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BastienBenard
approved these changes
May 23, 2023
Comment on lines
+141
to
+143
| @SecuredAction(RecallRights.ZIMBRA_RECALL_ADMIN) | ||
| public void initRecallAdminRight(final HttpServerRequest request) { | ||
| } |
There was a problem hiding this comment.
Perso je fais ça sur Formulaire et j'aime bien : ça permet d'avoir le droit initialisé par une fonction dédiée plutôt que par une fonction random dans tes controllers et au passage du coup qu'elle est un nom parlant associé
qperie
approved these changes
May 25, 2023
Comment on lines
+141
to
+143
| @SecuredAction(RecallRights.ZIMBRA_RECALL_ADMIN) | ||
| public void initRecallAdminRight(final HttpServerRequest request) { | ||
| } |
There was a problem hiding this comment.
Perso je fais ça sur Formulaire et j'aime bien : ça permet d'avoir le droit initialisé par une fonction dédiée plutôt que par une fonction random dans tes controllers et au passage du coup qu'elle est un nom parlant associé
aymericdevriesere
force-pushed
the
MZI-216
branch
from
14bd85c to
56de4a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Update admin recall rights to enable all ADML and ADMC to accept, list and delete recalls.
Checklist tests
Issue ticket number and link
[ MZI-216 ]
https://jira.support-ent.fr/browse/MZI-216
Checklist before requesting a review (magic string, indentation, comment/documentation...)