Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Challenge documentation should move to challenges itself #75

Closed
nbaars opened this issue Nov 24, 2021 · 1 comment · Fixed by #84
Closed

Challenge documentation should move to challenges itself #75

nbaars opened this issue Nov 24, 2021 · 1 comment · Fixed by #84
Assignees

Comments

@nbaars
Copy link
Collaborator

nbaars commented Nov 24, 2021

The asciidoc code within challenge.html should be simplified. We can move this to the Challenge classes. This way the decision is no longer in Thymeleaf removing

<div th:if="${ environment =='gcp'} and ${ challengeNumber  &gt; 8} "
         class="explanation">
        <div th:replace="doc:challenge__${challengeNumber}+'-gcp'__.adoc"></div>
    </div>
    <div th:if="${ environment !='gcp'}"
         class="explanation">
        <div th:replace="doc:challenge__${challengeNumber}__.adoc"></div>
    </div>
@commjoen
Copy link
Collaborator

I guess this can best be done when #35 and #40 are done :), as this kind of interacts with both

commjoen added a commit that referenced this issue Nov 28, 2021
@commjoen commjoen self-assigned this Nov 28, 2021
commjoen added a commit that referenced this issue Nov 28, 2021
commjoen added a commit that referenced this issue Nov 28, 2021
commjoen added a commit that referenced this issue Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants