Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #75 (small ui updates as well) #84

Merged
merged 6 commits into from
Nov 29, 2021
Merged

Conversation

commjoen
Copy link
Collaborator

@commjoen commjoen commented Nov 28, 2021

Thank you for submitting a pull request to the WrongSecrets app!
Fixes #75

@commjoen commjoen changed the title Draft: WIP for #75 (small ui updates as well) Fix for #75 (small ui updates as well) Nov 28, 2021
@commjoen commjoen requested a review from nbaars November 28, 2021 18:48
@commjoen
Copy link
Collaborator Author

commjoen commented Nov 28, 2021

Instead of overriding for all challenges can we change the adoc files a bit so the default case would just read challenge1.adoc for example? (based on classname). You can still override the method if you like for more complex situations

For now, I have a centralized approach, this should make it a lot cleaner already :-) 👍.maybe we can revise the adoc naming itself when we have more challenges?

@commjoen
Copy link
Collaborator Author

This is not necessary if you add the challenge itself to the model. I'm changing this a bit already in another branch. Also solves the looping in the html template

i rather see this in a next iteration ;-) / aka your branch with this integrated into it :).

@commjoen commjoen merged commit 0c73407 into master Nov 29, 2021
@commjoen commjoen deleted the challenge-explanation branch November 29, 2021 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Challenge documentation should move to challenges itself
3 participants