Support inlay hints #2357
Merged
Support inlay hints #2357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've based the O# api on the proposed inlay hint LSP api, https://github.com/microsoft/vscode-languageserver-node/blob/main/protocol/src/common/protocol.inlayHint.ts, which is pretty much stable now and 3.17 should be out shortly with this shape. I've also done a couple of refactors while touching code: * Update to C# 10. * Add some additional assert utils from roslyn, to make test results more readable and actionable. * Add an interpolated string handler for logging, so that interpolated strings can be used in logging without a perf penalty when they're uneeded.
This was referenced Mar 16, 2022
JoeRobich
approved these changes
Mar 16, 2022
src/OmniSharp.Abstractions/Models/v1/InlayHints/InlayHintRequest.cs
Outdated
Show resolved
Hide resolved
| return request.Hint; | ||
| } | ||
|
|
||
| var descriptionTags = await roslynHint.GetDescrptionAsync(document, CancellationToken.None); |
There was a problem hiding this comment.
Opened dotnet/roslyn#60217 for this typo
…ce.cs Co-authored-by: Joey Robichaud <[email protected]>
…st.cs Co-authored-by: Joey Robichaud <[email protected]>
|
I need to adjust one test to account for platform differences ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've based the O# api on the proposed inlay hint LSP api, https://github.com/microsoft/vscode-languageserver-node/blob/main/protocol/src/common/protocol.inlayHint.ts, which is pretty much stable now and 3.17 should be out shortly with this shape. I've also done a couple of refactors while touching code: