Clean up MSBuild environment initialization and allow it to use Visual Studio 2017 if it's present #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l Studio 2017 if it's present Fixes dotnet/vscode-csharp#1368 This change ensures that OmniSharp will use the MSBuild tools installed with Visual Studio 2017 if they're present on the machine. This allows OmniSharp to properly handle VS 2017 projects where the targets/tasks aren't include with OmniSharp's local MSBuild, such as WebApplication projects as reported in the bug listed above. If VS 2017 is not on the machine, OmniSharp will continue to use its local MSBuild which has a fallback to the Microsoft Build Tools for targets/tasks that it can't find. I've also taken the opportunity to clean up a lot of the MSBuild environment initialized code and project file processing.
david-driscoll
approved these changes
Apr 8, 2017
|
Thanks! |
filipw
reviewed
Apr 9, 2017
| var msbuildFolder = Path.Combine(AppContext.BaseDirectory, "msbuild"); | ||
| // If MSBuild can locate VS 2017 and set up a build environment, we don't need to do anything. | ||
| // MSBuild will take care of itself. | ||
| if (MSBuildHelpers.TryGetVisualStudioBuildEnvironment()) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/vscode-csharp#1368
This change ensures that OmniSharp will use the MSBuild tools installed with Visual Studio 2017 if they're present on the machine. This allows OmniSharp to properly handle VS 2017 projects where the targets/tasks aren't include with OmniSharp's local MSBuild, such as WebApplication projects as reported in the bug listed above. If VS 2017 is not on the machine, OmniSharp will continue to use its local MSBuild which has a fallback to the Microsoft Build Tools for targets/tasks that it can't find.
I've also taken the opportunity to clean up a lot of the MSBuild environment initialized code and project file processing.