Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disabled add train button #8172

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

achrafmohye
Copy link
Contributor

Closes #8170

@achrafmohye achrafmohye requested a review from a team as a code owner July 25, 2024 08:23
@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 28.13%. Comparing base (4070d78) to head (c703729).
Report is 3 commits behind head on dev.

Files Patch % Lines
...cations/operationalStudies/views/v2/ScenarioV2.tsx 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #8172      +/-   ##
============================================
- Coverage     28.14%   28.13%   -0.02%     
+ Complexity     2120     2116       -4     
============================================
  Files          1302     1302              
  Lines        158970   158963       -7     
  Branches       3182     3179       -3     
============================================
- Hits          44740    44720      -20     
- Misses       112321   112334      +13     
  Partials       1909     1909              
Flag Coverage Δ
core 75.40% <ø> (-0.03%) ⬇️
editoast 70.37% <ø> (-0.04%) ⬇️
front 9.98% <0.00%> (-0.01%) ⬇️
gateway 2.03% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 73.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Uriel-Sautron Uriel-Sautron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !! Tested

Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thank you

@SharglutDev SharglutDev enabled auto-merge July 25, 2024 08:39
@SharglutDev SharglutDev added this pull request to the merge queue Jul 25, 2024
@flomonster flomonster removed this pull request from the merge queue due to a manual request Jul 25, 2024
@flomonster flomonster merged commit f6bbedd into dev Jul 25, 2024
20 checks passed
@flomonster flomonster deleted the ame/front/8170-fix-disabled-add-train-button branch July 25, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't add train anymore
5 participants