Fix train displaying as not honored despite respecting times & stop time #8699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #8699 +/- ##
============================================
- Coverage 36.92% 36.90% -0.02%
Complexity 2213 2213
============================================
Files 1255 1255
Lines 114109 114119 +10
Branches 3186 3188 +2
============================================
- Hits 42135 42121 -14
- Misses 70081 70103 +22
- Partials 1893 1895 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kmer2016
force-pushed
the
cnh/fix-not-honored-train
branch
2 times, most recently
from
beeef07 to
92f11e6
Compare
kmer2016
changed the title
kmer2016
changed the title
kmer2016
force-pushed
the
cnh/fix-not-honored-train
branch
from
92f11e6 to
17a3acc
Compare
theocrsb
reviewed
Sep 2, 2024
|
Works fine for me. Good job ! |
Maymanaf
approved these changes
Sep 4, 2024
flomonster
approved these changes
Sep 4, 2024
The bug was caused by attempting to match the schedule constraint data with the train's arrival times at each point along its route. The first table (`trainSchedule.schedule`) contains only points with time constraints, while the second table (`trainSummary.path_item_times_final`) includes the train's arrival times for all intermediate points, including those without time constraints. So, matching the indices between the two tables doesn't work because the first table skips points that aren't constrained. front: improve complexity used to find index of schedule on path front: add unit tests - Add test for case when trainSchedule does not have a schedules array - Add test for case when no matching index is found for a schedule on the path
kmer2016
force-pushed
the
cnh/fix-not-honored-train
branch
from
f4c2a00 to
4615d97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #8654