Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[scenario] Make sure scenario is valid #73

Merged
merged 2 commits into from
Apr 25, 2024
Merged

[scenario] Make sure scenario is valid #73

merged 2 commits into from
Apr 25, 2024

Conversation

goldyfruit
Copy link
Member

@goldyfruit goldyfruit commented Apr 18, 2024 •
edited
Loading

This checks:

  • Scenario file not empty
  • Minimum 7 options are required
  • Check if the provided option is valid

@goldyfruit goldyfruit added the bug Something isn't working label Apr 18, 2024
@goldyfruit goldyfruit added this to the Quake milestone Apr 18, 2024
@goldyfruit goldyfruit self-assigned this Apr 18, 2024
@goldyfruit goldyfruit marked this pull request as draft April 18, 2024 23:10
@goldyfruit goldyfruit mentioned this pull request Apr 18, 2024
Closed
@suvanbanerjee
Copy link
Contributor

is there anything i can help with ?

@goldyfruit
Copy link
Member Author

is there anything i can help with ?

Not that much on this one, I just need to fix one more BATS tests and we are good to go. 👍

@suvanbanerjee
Copy link
Contributor

@goldyfruit in
https://github.com/OpenVoiceOS/ovos-installer/pull/73/files#diff-a075e8010ef0831e7a8c920a9a4045b34e48f217894eb7a20ada980b81dbc87fR57-R60
the values are yes and no for rapsberry_pi_tuning but in our YAML files it should be true or false.

@goldyfruit
Copy link
Member Author

@goldyfruit in https://github.com/OpenVoiceOS/ovos-installer/pull/73/files#diff-a075e8010ef0831e7a8c920a9a4045b34e48f217894eb7a20ada980b81dbc87fR57-R60 the values are yes and no for rapsberry_pi_tuning but in our YAML files it should be true or false.

This is expected as true come from the YAML file.

@goldyfruit goldyfruit marked this pull request as ready for review April 25, 2024 00:22
@goldyfruit goldyfruit merged commit 7c64863 into main Apr 25, 2024
3 of 4 checks passed
@goldyfruit goldyfruit deleted the fix/issue_72 branch April 25, 2024 00:23
@suvanbanerjee suvanbanerjee mentioned this pull request Apr 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@goldyfruit goldyfruit

Labels
bug Something isn't working
Projects
None yet
Milestone
Quake
Development

Successfully merging this pull request may close these issues.
2 participants
@goldyfruit @suvanbanerjee