-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Installer allowing invalid config.yaml files #77
Conversation
@suvanbanerjee Thanks.
|
I tested it locally by running it not usings the BATS tests. and it works by saying seceniro not supported
|
@goldyfruit I think the failed bats test in #73 is also due to the invalid |
Just to make sure, your file is named |
my bad it's scenario.yaml only. 😅 https://pastebin.com/wV0AkayA here is the full log for the output when using |
I'm gonna test it later today. 👍 |
Just tested it using github actions and it is still failing the bats test. |
is an invalid
config.yaml
file but still is considered valid and installs ovos.Fix: used conditional statements to validate each options correctness.
Closes: #72